December monthly meeting agenda #972
Comments
|
User csanders-git commented on date 2017-11-27 14:36:09: i'm actually not sure about this. My gut says that the transform will be faster but if the regex engine is already booted up for something different the performance is probably negligible |
|
User dune73 commented on date 2017-11-27 14:54:17: It's probably worth to test in detail before we chance anything. |
|
User fgsch commented on date 2017-11-27 18:17:43: My gut feeling says the opposite, the regexp should be faster or equal. Also there is no need to pre-convert the whole input to lowercase if it's not going to match further down the line. For large inputs this might be considerable. It'd be great to see some benchmarks though. |
|
User lifeforms commented on date 2017-12-04 20:56:58: Handling of case (?:in)?sensitive items - To set a standard for future development, we need to know which way has better performance. spartantri is going to try to do some benchmarks on Apache, so we can revisit the issue next month. |
|
User lifeforms commented on date 2017-12-04 20:57:32: Open issues: Yeah, there are many open issues.. All reviewers should try to look at their assigned issues if they can. Many new PRs are about the test suite, which is not working yet for everyone. These issues fortunately seem small. They are assigned to csanders-git. |
Issue originally created by user spartantri on date 2017-11-27 14:27:48.
Link to original issue: SpiderLabs/owasp-modsecurity-crs#972.
Case sensitive items (additional infos)
There are rules with different approaches
(t:lowercase)(?i)(?:GET|POST)(?:[eEiIoOuUyY]acute)It maybe easier to use
t:lowercaseand convert all the regex to lowercase and add a warning inCONTRIBUTING.mdThe text was updated successfully, but these errors were encountered: