8000 Clean up `tx.anomaly_score` · Issue #1083 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clean up tx.anomaly_score #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CRS-migration-bot opened this issue May 13, 2020 · 1 comment
Closed

Clean up tx.anomaly_score #1083

CRS-migration-bot opened this issue May 13, 2020 · 1 comment

Comments

@CRS-migration-bot
Copy link

Issue originally created by user studersi on date 2018-05-07 14:31:56.
Link to original issue: SpiderLabs/owasp-modsecurity-crs#1083.

After discussing PR SpiderLabs/owasp-modsecurity-crs#1076 with dune73, it became clear that tx.anomaly_score could use refactoring.

While going through all the rules, the variable is reused multiple times for different purposes. It might be better to use separate variables for each purpose and only collect the total intx.anomaly_score at the very end.
@CRS-migration-bot
Copy link
Author

User fgsch commented on date 2019-10-20 21:59:50:

Hi there. We'll certainly welcome a PR to clean up tx.anomaly_score.
As this issue has not been updated in over a year and the next steps are clear I'm going to close it for now.

@studersi studersi mentioned this issue Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CRS-migration-bot
0