8000 Added 'ver' action with current version to all necessary rules (fix for #650) · Issue #1750 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added 'ver' action with current version to all necessary rules (fix for #650) #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CRS-migration-bot opened this issue May 13, 2020 · 0 comments
Closed

Added 'ver' action with current version to all necessary rules (fix for #650) #1750

CRS-migration-bot opened this issue May 13, 2020 · 0 comments

Comments

@CRS-migration-bot
Copy link

Issue for tracking original pull request created by user airween on date 2020-04-29 19:45:05.
Link to original PR: SpiderLabs/owasp-modsecurity-crs#1750.

HEAD is: d807570
BASE is: cf57fd5
This PR fixes #650.

A small footnote for this modification: I generated a spreadsheet for the better visibility of changes.

The column E/F contains the status of actions before, J/K after the modification. The PL control is a formula, if the id of the rule is ended up with ...011, ...012. If it's "yes", then Need 'ver' act. is "no". This means the PL control rules didn't got the ver action now.

Need to add column is "yes" if the action should be at rule (it's not PL control rule) but there isn't yet. If this is "yes" the script added it.

If the rule needs the ver and contains it after the modification, then the Check field is OK - but doesn't matter that the action was present or not. All fields must be OK in this column.

The Changed fields indicates that a change has been made (was not present before - it present after).

Definition of PL control:

id < 1000000 and (id % 1000 >= 100 or id % 1000 <= 10)
  or
id > 1000000

I think this form describes the rules with skipAfter actions and doesn't affect exclusion rules. The modification affects all other SecRule and SecAction entries.

Let me know if there are still missing any ver action, or if it's unnecessary.

Note, of course, the modification follows the expected sequence of actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CRS-migration-bot
0