10000 v3.3.6 release missing in v4 CHANGES.MD · Issue #3831 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

v3.3.6 release missing in v4 CHANGES.MD #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RedXanadu opened this issue Sep 24, 2024 · 6 comments · Fixed by #3867
Closed

v3.3.6 release missing in v4 CHANGES.MD #3831

RedXanadu opened this issue Sep 24, 2024 · 6 comments · Fixed by #3867
Labels
📖 documentation Improvements or additions to documentation 🐛 bug Something isn't working 👇 complexity: low 🥇 good first issue Good for newcomers

Comments

@RedXanadu
Copy link
Member
RedXanadu commented Sep 24, 2024 •
edited
Loading

Describe the bug

v3.3.6 release notes are missing in the v4 version of CHANGES.MD.

Actual behaviour

The v3 and v4 versions of CHANGES.MD have drifted slightly over the past releases (e.g. updated release notes in both the v3 and v4 branches, due to backports to v3 on the separate v3 branch.)

What we should do to fix

  1. Make sure that the v4 version has all the info of all releases (I think it's just 3.3.6 that's missing.)
  2. Double/triple-check that nothing else is missing / no other drift with the v4 version of CHANGES.MD.
@RedXanadu RedXanadu added 🐛 bug Something isn't working 📖 documentation Improvements or additions to documentation 👇 complexity: low 🥇 good first issue Good for newcomers labels Sep 24, 2024
@LuckyyS0da
Copy link

Hello! I would like to work on this.

@dune73
Copy link
Member
dune73 commented Oct 3, 2024

Thank you @LuckyyS0da

@fzipi
Copy link
Member
fzipi commented Oct 8, 2024

Hi @LuckyyS0da ! Do you need anything for pushing this one?

@LuckyyS0da
Copy link
LuckyyS0da commented Oct 8, 2024 •
edited
Loading

@fzipi To be honest, I am new to open contributions and wanted to explore a bit and then landed on this. I somewhat understood the issue but don't know how to implement it.

@fzipi
Copy link
Member
fzipi commented Oct 9, 2024

@LuckyyS0da No problem. You should take the text from the changes file for v3.3.6 and add them here. You can do it just by pressing here and then saving the changes. It will create a new branch for you, and then you create a new pull request. Easy!

@LuckyyS0da
Copy link

Thank you @fzipi
I did like what you told me and created a pull request after adding the text to v4.0

@fzipi fzipi mentioned this issue Oct 9, 2024
Closed
@fzipi fzipi mentioned this issue Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📖 documentation Improvements or additions to documentation 🐛 bug Something isn't working 👇 complexity: low 🥇 good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
4 participants
@dune73 @fzipi @RedXanadu @LuckyyS0da
0