8000 SQL operators can be one or more characters · Issue #3842 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SQL operators can be one or more characters #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Xhoenix opened this issue Oct 2, 2024 · 4 comments · Fixed by #3845
Closed

SQL operators can be one or more characters #3842

Xhoenix opened this issue Oct 2, 2024 · 4 comments · Fixed by #3845

Comments

@Xhoenix
Copy link
Member
Xhoenix commented Oct 2, 2024

Is there a reason for not using [|&<>*\/%=^+-]+ in the following regex?

[|&<>*\/%=^+-]

@fzipi
Copy link
Member
fzipi commented Oct 4, 2024

If it is an operator, w probably don't need more than three of these. Also, as we are using it in more than one place, probably it is better to extract them and use it in an include file, so at least we use the same everywhere.

Good find.

@fzipi
Copy link
Member
fzipi commented Oct 4, 2024

I meant this rule and 942120, for example.

@Xhoenix
Copy link
Member Author
Xhoenix commented Oct 4, 2024

@fzipi should I replace the corresponding PR for this with {1,3} instead of a +?

@fzipi
Copy link
Member
fzipi commented Oct 4, 2024

Yes sounds more reasonable. But then the real refactor should come from the inclusion, right?

Meaning: it doesn't matter too much because if we change it for all the operators in their right form, there is no need for "counting" 1..3 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
0