8000 Report errors, warnings, lints, rustfmt, etc in the github PR · Issue #2 · crate-ci/meta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Report errors, warnings, lints, rustfmt, etc in the github PR #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Si 8BF2 gn up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
epage opened this issue Feb 17, 2018 · 0 comments
Open

Report errors, warnings, lints, rustfmt, etc in the github PR #2

epage opened this issue Feb 17, 2018 · 0 comments
Labels
proposal T-cargo

Comments

@epage
Copy link
Contributor
epage commented Feb 17, 2018

Original discussion: https://users.rust-lang.org/t/handling-warnings-in-a-ci/15669/12

This simplifies life for the contributor because they don't have to dig through logs to find what they broke and why.

This simplifies life for any mentors because this makes it easier to have a conversation about whats going wrong.

For maintainers that don't want warnings, etc to break their build, this provides them an avenue to still keep abreast on what warnings are occurring.

Proposal

A cargo wrapper that will invoke the specified cargo command with --message-format=json that then takes the file/line information and creates a review calling out these sections of the file

Open Questions

  • What should it do for messages without file/line?
  • How does it identify the PR that started it?
  • How does it avoid spamming for the same issue?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal T-cargo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage
0