8000 RFE: load config also from `.config/committed.toml` · Issue #419 · crate-ci/committed · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

RFE: load config also from .config/committed.toml #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scop opened this issue Dec 24, 2024 · 1 comment
Open

RFE: load config also from .config/committed.toml #419

scop opened this issue Dec 24, 2024 · 1 comment

Comments

@scop
Copy link
Contributor
scop commented Dec 24, 2024

It would be nice to load config by default from .config/committed.toml, in addition to a top level committed.toml and the path configurable with the command line option.

There are some initiatives for this that document the full rationale for this so I won't repeat that here, for example

This is not widely used practice yet, but IMO makes great sense. The pi0/config-dir of the above seems to be the most active of the initiatives at the moment, and documents the motivation as well as why the command line option to set a custom config is not in general a proper replacement for this.

As far as committed goes, the number of different environments from which it is launched under a normal workflows is not that big, so using --config .config/committed.toml is more scalable than with other kinds of tools

  • git commit-msg hooks
  • CI pipelines for checking PR branches

However, that still needs to be duplicated in two places, and for example if one wants that when using the committed GH action, one needs to duplicate the action's default args, can't just append --config there.

If accepted, I can have a look at implementing this.

@epage
Copy link
Collaborator
epage commented Feb 18, 2025

In committed, I only support

  • committed.toml

However, in typos, I support

  • typos.toml
  • _typos.toml
  • .typos.toml

The option to affect sort order but not hide via _ I think is an important aspect of typos and I feel hesitant to support a "standard" that is pushing for hiding these files. I made a similar comment at pi0/config-dir#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
0