8000 RFE: load config also from `.config/committed.toml` · Issue #419 · crate-ci/committed · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
RFE: load config also from .config/committed.toml #419
Open
@scop

Description

@scop

It would be nice to load config by default from .config/committed.toml, in addition to a top level committed.toml and the path configurable with the command line option.

There are some initiatives for this that document the full rationale for this so I won't repeat that here, for example

This is not widely used practice yet, but IMO makes great sense. The pi0/config-dir of the above seems to be the most active of the initiatives at the moment, and documents the motivation as well as why the command line option to set a custom config is not in general a proper replacement for this.

As far as committed goes, the number of different environments from which it is launched under a normal workflows is not that big, so using --config .config/committed.toml is more scalable than with other kinds of tools

  • git commit-msg hooks
  • CI pipelines for checking PR branches

However, that still needs to be duplicated in two places, and for example if one wants that when using the committed GH action, one needs to duplicate the action's default args, can't just append --config there.

If accepted, I can have a look at implementing this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0