8000 [Bug] pullsecret defined API call should be preset aware · Issue #2950 · crc-org/crc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Bug] pullsecret defined API call should be preset aware #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #2970
gbraad opened this issue Jan 18, 2022 · 7 comments
Closed
Tracked by #2970

[Bug] pullsecret defined API call should be preset aware #2950

gbraad opened this issue Jan 18, 2022 · 7 comments
Assignees
@praveenkumar
Labels
kind/task Workable task points/1 priority/major resolution/invalid This doesn't seem right status/need more information Issue needs more information before it will be looked at status/stale Issue went stale; did not receive attention or no reply from the OP

Comments

@gbraad
Copy link
Contributor
gbraad commented Jan 18, 2022 •
edited
Loading

The current API call to determine if the pull-secret is given, is based on the openshift preset.
When we would use this in the tray, the API could possibly prevent the podman preset to start when the pull-secret is not defined.

This API call introduced to prevent the slow startup, as the pull-secret preflight check follows quite late. It would be quicker to check if the puyll-secret is there or not, provide a popup and continue.

The suggestion would be to make this API call aware of the preset and check if pull-secret is needed, based on this, and if defined when necessary. This way the tray does not need to check the configuration and preset value to determine this. It should not have to be aware of this logic.

This is needed for: gbraad-redhat/crc-tray-electron@2b5e773#r64088220 which solves: crc-org/tray-electron#61
@gbraad gbraad added kind/bug Something isn't working status/need triage kind/task Workable task priority/major points/1 and removed kind/bug Something isn't working status/need triage labels Jan 18, 2022
@gbraad gbraad moved this to Todo in Project planning Jan 18, 2022
@gbraad gbraad changed the title [Task] Is pullsecret defined API call should be preset aware [Task] pullsecret defined API call should be preset aware Jan 18, 2022
This was referenced Jan 18, 2022
Merged
Open
@praveenkumar
Copy link
Member

@gbraad the /pull-secret api is preset aware, I tested with curl and getting correct response.

✗ ./crc config view
- consent-telemetry                     : no
- network-mode                          : user
- preset                                : podman

✗ curl -IXGET --unix-socket ~/.crc/crc-http.sock http:/c/api/pull-secret  
HTTP/1.1 200 OK
Date: Tue, 18 Jan 2022 14:09:18 GMT
Content-Length: 0

✗ ./crc config unset preset
Successfully unset configuration property 'preset'
✗ ./crc config view        
- consent-telemetry                     : no
- network-mode                          : user
✗ curl -IXGET --unix-socket ~/.crc/crc-http.sock http:/c/api/pull-secret  
HTTP/1.1 404 Not Found
Date: Tue, 18 Jan 2022 14:13:27 GMT
Content-Length: 61
Content-Type: text/plain; charset=utf-8

@gbraad
Copy link
Contributor Author
gbraad commented Jan 19, 2022

The API call is correctly aware of the preset. I believe the issues, around not starting, are caused by #2949 Segment related timeouts.

@gbraad gbraad closed this as completed Jan 19, 2022
Repository owner moved this from Todo to Done in Project planning Jan 19, 2022
@gbraad gbraad removed the status in Project planning Jan 19, 2022
@gbraad gbraad added the resolution/wontfix This will not be worked on label Jan 19, 2022
@gbraad gbraad moved this to Done in Project planning Jan 19, 2022
@gbraad gbraad added resolution/invalid This doesn't seem right and removed resolution/wontfix This will not be worked on labels Jan 19, 2022
@adrianriobo adrianriobo mentioned this issue Jan 27, 2022
Closed
28 tasks
@gbraad gbraad reopened this Feb 14, 2022
@gbraad gbraad mentioned this issue Feb 14, 2022
Closed
@gbraad gbraad changed the title [Task] pullsecret defined API call should be preset aware [Bug] pullsecret defined API call should be preset aware Feb 14, 2022
@gbraad
Copy link
Contributor Author
gbraad commented Feb 14, 2022

It seems this does not always returned the expected value. I've seen two reports about this sometimes sending a 'not defined' (or perhaps an error?) and a reported case #3003

@gbraad
Copy link
Contributor Author
gbraad commented Feb 15, 2022

@anjannath can you add your findings here?

@stale
Copy link
stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale Issue went stale; did not receive attention or no reply from the OP label Apr 16, 2022
@cfergeau
Copy link
Contributor

Unclear if this is still an issue or not?

@stale stale bot removed the status/stale Issue went stale; did not receive attention or no reply from the OP label Apr 19, 2022
@cfergeau cfergeau added the status/need more information Issue needs more information before it will be looked at label Apr 19, 2022
@stale
Copy link
stale bot commented Jun 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale Issue went stale; did not receive attention or no reply from the OP label Jun 19, 2022
@stale stale bot closed this as completed Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@praveenkumar praveenkumar

Labels
kind/task Workable task points/1 priority/major resolution/invalid This doesn't seem right status/need more information Issue needs more information before it will be looked at status/stale Issue went stale; did not receive attention or no reply from the OP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gbraad @praveenkumar @cfergeau
0