8000 Onboarding process start again after exit tray on macos · Issue #2972 · crc-org/crc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Onboarding process start again after exit tray on macos #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #2970
adrianriobo opened this issue Jan 27, 2022 · 4 comments
Closed
Tracked by #2970

Onboarding process start again after exit tray on macos #2972

adrianriobo opened this issue Jan 27, 2022 · 4 comments
Labels
kind/bug Something isn't working os/macos priority/major

Comments

@adrianriobo
Copy link
Contributor

Steps:

  1. install
  2. onboarding
  3. start instance from tray
  4. exit tray
  5. click Codeready Containers icon

Expected

Tray should be accessible again

Actual

Onboaring process start again
@adrianriobo
Copy link
Contributor Author

related to crc-org/tray-electron#116 and crc-org/tray-electron#108

@gbraad
Copy link
Contributor
gbraad commented Jan 28, 2022

Onboarding check fails because the crc setup --check-only is not handled accordingly/fails?

@praveenkumar
Copy link
Member

In mac crc setup --check-only is always going to fail when you exit from the tray because this check do something launchctl list | grep crc.tray | awk '{print $1}' on windows the tray part is taken care by installer so crc setup --check-only fails first time when bundle is not extracted. We need to do similar hack to mac side to have plist file created during the install time instead crc setup part and ignore that check.

@gbraad gbraad transferred this issue from crc-org/tray-electron Jan 28, 2022
@gbraad gbraad mentioned this issue Jan 28, 2022
Closed
28 tasks
@gbraad gbraad added os/macos priority/major kind/bug Something isn't working labels Jan 28, 2022
@gbraad gbraad mentioned this issue Jan 28, 2022
Closed
@anjannath
Copy link
Member

This is also fixed in #2971

the on-boarding process was starting again since crc setup --check-only was failing :

In mac crc setup --check-only is always going to fail when you exit from the tray because this check do something launchctl list | grep crc.tray | awk '{print $1}'

Repository owner moved this from Todo to Done in Project planning Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working os/macos priority/major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gbraad @praveenkumar @adrianriobo @anjannath
0