8000 install LVMS operator for openshift preset · Issue #867 · crc-org/snc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

install LVMS operator for openshift preset #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anjannath opened this issue Apr 3, 2024 · 5 comments
Closed

install LVMS operator for openshift preset #867

anjannath opened this issue Apr 3, 2024 · 5 comments
Assignees
@anjannath
Labels
enhancement New feature or request

Comments

@anjannath
Copy link
Member

By following the installation guide on: https://docs.openshift.com/container-platform/4.15/storage/persistent_storage/persistent_storage_local/persistent-storage-using-lvms.html#install-lvms-operator-cli_logical-volume-manager-storage

create the namespace, operatorgroup and subscription resources during snc leaving the LVMCluster crd resource to be created upon crc start
@anjannath anjannath added the enhancement New feature or request label Apr 3, 2024
@anjannath anjannath self-assigned this Apr 3, 2024
@anjannath anjannath moved this to Work In Progress in Project planning: crc Apr 3, 2024
This was referenced Apr 3, 2024
Closed
Closed
Closed
@praveenkumar
Copy link
Member

I am thinking it again and following points what I observe

  • Changes are what is part of the operator installation which also means we have to maintain it for different OCP releases (major/minor) and if something change we have to update it (like we are doing for current hostpath operator).
  • Since this is installed during snc does that mean any other image is pulled or it is just the crd installation and there is no change in bundle size and default resource if the user not consuming it?

@anjannath
Copy link
Member Author 
* Changes are what is part of the operator installation which also means we have to maintain it for different  OCP releases (major/minor) and if something change we have to update it (like we are doing for current hostpath operator).

for the hostpath-provisioner we have to maintain the versions of the images because its not installed as a operator, but we create daemonsets and some service plus rbac stuff, but the LVMS is a operator managed by OLM so for this we don't have to bump versions of the images, we just have to create the subscription and the correct version is installed by OLM..

the two resources that we are creating for this during SNC (operator-group and subscription) don't have any version related fields in the spec

* Since this is installed during snc does that mean any other image is pulled or it is just the crd installation and there is no change in bundle size and default resource if the user not consuming it?

yes images are pulled, there's an increase of ~100MB in bundle size, and it creates a deployment with 1 replica after the operator is installed

@praveenkumar
Copy link
Member

yes images are pulled, there's an increase of ~100MB in bundle size, and it creates a deployment with 1 replica after the operator is installed

In this case should we just copy those artifacts to VM under /opt/crc/lvms and then when user really want to consume that then only apply those to cluster? This way we don't have to increase the bundle size and extra deployment and the config will be also part of bundle?

@anjannath
Copy link
Member Author

yes images are pulled, there's an increase of ~100MB in bundle size, and it creates a deployment with 1 replica after the operator is installed

In this case should we just copy those artifacts to VM under /opt/crc/lvms and then when user really want to consume that then only apply those to cluster? This way we don't have to increase the bundle size and extra deployment and the config will be also part of bundle?

this is done in snc to reduce the time the user has to wait for crc start to finish, if we install the operator during crc start it increases the start time by around ~2mins, i mentioned about the increase in start time also in #854 (comment)

8000 @anjannath anjannath moved this from Work In Progress to Ready for review in Project planning: crc Jun 6, 2024
@anjannath anjannath moved this from Ready for review to Work In Progress in Project planning: crc Jun 6, 2024
@anjannath anjannath moved this from Work In Progress to Ready for review in Project planning: crc Jul 16, 2024
@anjannath
Copy link
Member Author

We've decided not to pursue this, as user can install the operator/perform the setup operations even after starting the cluster

@github-project-automation github-project-automation bot moved this from Ready for review to Done in Project planning: crc Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anjannath anjannath

Labels
enhancement New feature or request
Projects
Project planning: crc
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@praveenkumar @anjannath
0