8000 [Question] Expected flow for on boarding process · Issue #99 · crc-org/tray-electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 2, 2023. It is now read-only.

[Question] Expected flow for on boarding process #99

Open
Tracked by #2970
adrianriobo opened this issue Jan 20, 2022 · 4 comments
Open
Tracked by #2970

[Question] Expected flow for on boarding process #99

adrianriobo opened this issue Jan 20, 2022 · 4 comments
Assignees
@adrianriobo
Labels
question Further information is requested

Comments

@adrianriobo
Copy link
adrianriobo commented Jan 20, 2022 •
edited
Loading

Tested on windows environment, removing and old version:

  • delete cluster
  • close tray
  • use the installer to remove previous version

When installing a new one, if the CRC home folder was not deleted the on boarding process is not shown when the computer is restarted. Instead the tray is already running.

How does this impact related to an upgrade scenario?. Do we expect to start with an on boarding process on every upgrade?
@adrianriobo
Copy link
Author

I think on mac this is not happening but need to run exact same use case. I will add more info when I will test it

@gbraad gbraad moved this to In Progress in Project planning Jan 20, 2022
@gbraad
Copy link
Collaborator
gbraad commented Jan 21, 2022 •
edited
Loading

It is decided that no onboarding is necessary. This is based on the fact that the machine has been setup:

$ crc setup --check-only

is used to provide this feedback.

if the CRC home folder was not deleted

onboarding and setup is a single time event. All actions, like providing the pull-secret and changing the preset are possible from the configuration. So, what extra does an 'onboarding' (familiarizing a new user) have when an upgrade is done?

Note: if you believe a 'forced' onboarding should be performed, this could be done with a parameter flag, a placeholder file, etc. But this would be a feature request.

@gbraad gbraad added question Further information is requested and removed os/windows labels Jan 21, 2022
@adrianriobo
Copy link
Author
adrianriobo commented Jan 21, 2022 •
edited
Loading

Well, not sure which is the best approach:

To upgrade you run crc cleanup this means next installation will require pull secret again. On the other hand If you do not do the crc cleanup how do you (or the installer) take care of removing caches from previous versions (unused bundles).

Still not saying on boarding is required but need to clarify the upgrade path (probably during next sprint) and be consistent across platforms. As currently, with crc home folder in place; windows not show on boarding and macos does.

@gbraad
Copy link
Collaborator
gbraad commented Jan 26, 2022 •
edited
Loading

crc cleanup
how do you (or the installer) take care of removing caches from previous versions (unused bundles).

This is not a flow that has been described or handled yet.
It would be ideal not to resort to the command line in that case.
Either we remove old caches automagically when not in use, or we decide this needs a dialog or configuration option.

This ties in to: crc-org/crc#484 and a comment such as: crc-org/crc#1860 (comment)

I would consider this an issue with the installer. We need to inform the user an uninstall happens (as it does on Windows when upgrading). But this should also remove the instance and the cache.

Ref: #91

@adrianriobo adrianriobo mentioned this issue Jan 27, 2022
Closed
28 tasks
@gbraad gbraad changed the title Expected flow for on boarding process [Question] Expected flow for on boarding process Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adrianriobo adrianriobo

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gbraad @adrianriobo
0