8000 [Bug] JMC Agent Probe Template schema is in the wrong package · Issue #450 · cryostatio/cryostat-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Bug] JMC Agent Probe Template schema is in the wrong package #450

New issue

Have a question about this project? Sign up for a free GitHub 8000 account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andrewazores opened this issue Aug 29, 2024 · 3 comments
Open

[Bug] JMC Agent Probe Template schema is in the wrong package #450

andrewazores opened this issue Aug 29, 2024 · 3 comments
Assignees
@Josh-Matsuoka
Labels
bug Something isn't working needs-documentation

Comments

@andrewazores
Copy link
Member
andrewazores commented Aug 29, 2024 •
edited
Loading

See #398

https://github.com/cryostatio/cryostat-core/blob/main/cryostat-core/src/main/resources/io/cryostat/core/agent/jfrprobes_schema.xsd

This causes probe template uploads to fail because the template service cannot load the schema to validate the uploaded file.
@andrewazores andrewazores added the bug Something isn't working label Aug 29, 2024
@andrewazores andrewazores moved this to In progress in 3.0.1 release Aug 29, 2024
@andrewazores andrewazores moved this to In progress in 4.0.0 release Aug 29, 2024
@andrewazores
Copy link
Member Author 
$ tree cryostat-core/src/main/resources/
cryostat-core/src/main/resources/
├── config
│   └── logging.properties
├── io
│   └── cryostat
│       └── core
│           └── agent
│               └── jfrprobes_schema.xsd
├── org
│   └── openjdk
│       └── jmc
│           ├── flightrecorder
│           │   └── configuration
│           │       └── events
│           │           ├── jfc_v1.xsd
│           │           └── jfc_v2.xsd
│           └── rjmx
│               └── subscription
│                   └── internal
│                       └── mrimetadata.xml

Do we still need the org.openjdk.jmc XML and XSD files here after we removed the JMC embedded sources fork?

@Josh-Matsuoka Josh-Matsuoka mentioned this issue Aug 30, 2024
Merged
@Josh-Matsuoka
Copy link
Contributor

I don't see any uses of those anymore in core or cryostat3, they should be safe to remove but I'll double check.

This was referenced Sep 3, 2024
Merged
Closed
@andrewazores
Copy link
Member Author

@Josh-Matsuoka did you get a chance to check on whether those files can be removed?

@andrewazores andrewazores mentioned this issue Feb 27, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Josh-Matsuoka Josh-Matsuoka

Labels
bug Something isn't working needs-documentation
Projects
4.0.0 release
Status: In progress
3.0.1 release
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewazores @Josh-Matsuoka
0