8000 Pass through container_kwargs from run tags when using Docker · Issue #30651 · dagster-io/dagster · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Pass through container_kwargs from run tags when using Docker #30651
Open
@cooperellidge

Description

@cooperellidge

What's the use case?

Its seems runs can be launched with "ecs/memory" to set memory for containers running with ECS.

I'd like a similar functionality for regular Docker, where "docker/container_kwargs" can be used to override the container kwargs that may be specified in the dagster.yaml. This would enable me to set a global mem_limit for all containers but override this with run tags.

I think enabling "docker/container_kwargs" and merging that with the existing container kwargs makes sense, but we could even expose "docker/mem_limit" more directly. Handling JSON in the Dagster UI tags is not ideal.

Ideas of implementation

Use dagster-aws/ecs as inspiration for pulling in run tags and applying it to container contexts.

Additional information

When I get free time, I will attempt a PR. But if this can already be done, let me know.

I did try a few different tags and inspected the source code and couldn't see it being implemented.

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0