8000 fbad_create_ad has a problem with campaign_id argument · Issue #45 · daroczig/fbRads · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 22, 2024. It is now read-only.

fbad_create_ad has a problem with campaign_id argument #45

Open
13bzhang opened this issue Feb 9, 2017 · 2 comments
Open

fbad_create_ad has a problem with campaign_id argument #45

13bzhang opened this issue Feb 9, 2017 · 2 comments

Comments

@13bzhang
Copy link
13bzhang commented Feb 9, 2017

There is a problem with campaign_id in the function fbad_create_ad. In the version available on CRAN, you had campaign_id as an argument. But in the latest GitHub version, you don't. I think it might be because it's deprecated. Anyhow, not having campaign_id as an argument is causing problems. I get an error that says:

Error in missing(campaign_id) : 'missing' can only be used for arguments

I might try to do a fix and make a pull request.
@13bzhang 13bzhang changed the title fbad_create_ad has a problem with campaign_id fbad_create_ad has a problem with campaign_id argument Feb 9, 2017
@daroczig
Copy link
Owner

Thanks for #46, I will test and merge soon

@bjeavons
Copy link
Contributor
bjeavons commented May 2, 2017

Left a comment at https://github.com/cardcorp/fbRads/pull/46/files#r114410067 but in summary, campaign ID is not a requirement for creating a ad.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bjeavons @daroczig @13bzhang
0