Longitudinal vertical stripes appear in the right half of the exported images. #16984
Comments
|
The last time I did a test of these as you suggested, I could no longer use the version of DT I was using because the development version I tested made changes to the database, and it was no longer compatible with my version of DT. So, as always, I have no problem testing the development version, as long as you can assure me that I will be able to continue using the database with my current version of DT. |
You can start the development version w/ the separate .config folder and separate database (and disable sidecars as well). |
|
I was unaware of this possibility. Thank you very much for providing the link on how to do it. I will try it tonight and let you know the result. I will also attach the output file you asked for. Thanks |
Always good to have more testers, hope you'll keep checking out future development versions as well 😉 |
|
In that link talk about a compiled version, that should be in |
|
Hello, |
|
jif
As I opened this thread and was waiting to have an "official" from my distro, now I can say that v4.8.0 has not fixed issue. jlfrucot, could you try to disable filters till you find if it's same filter "Contrast Equalizer" or maybe some other one? |
|
Multiple export with same image produce same issue. |
|
There was an issue in 4.8 for jpeg (in general all 8bit) exports that has been fixed in 4.8.1 You might try to compile yourself to check ... |
|
Ok, this seems to be the same issue related to tiled scaling at the end of the processing pipe. |
|
I don't know if when you mention rescaling you are referring to this case or to the referenced case when exporting to JPG, that's why I want to clarify that in this case, I haven't applied any rescaling module. The export is at the original RAW size. |
|
When I opened this thread about the problem, I incorporated all the information I thought necessary. I have not been asked for more information. But I was right to reply to your comment above because from what you say, something incorrect has been inferred. The word "upscayl" is the name of the original file, which, before I started processing it with Darktable, is indeed rescaled to a larger size. In the information I attached from the beginning and in the screenshot, you can clearly see ALL the modules I have applied (none referred to scaling) and I have also specified which module is the one that seems to produce the problem. I don't know if I have not been understood, but I can explain it in another way if this is the case. I repeat, it is only from the application of the "contrast equaliser" module that the export generates the problem. If more information is required, please let me know. |
|
I have understood that you can only reproduce with that specific module. There is another issue that would explain the garbled output. and that issue has been understood and will be fixed first as it's a major issue requiring a fast fix. About your issue, I can't reproduce yet. What is definitely required from you is a log file using dt 4.8 with option '-d pipe -d opencl'. That would help to get an idea about what's happening. |
|
In 10 hours I will be able to attach the output with this command. In any case, it is important to keep in mind that not being able to reproduce a problem or that nobody else has reported it, does not mean that it does not exist. I say this from experience. It happened to me very recently with another application that, after an update, started to crash. I identified that it was related to non-ASCII characters in the path, but after a week of the developers not being able to reproduce the problem (despite making it clear what it was) they closed the thread. Two days later, a Portuguese user reported the same problem, for the same reason. Finally, they managed to solve it (I don't remember what changes in the code produced the problem, nor are they relevant). And I tell this because I have only been able to discover that it is from the application of this module that the problem occurs. From there, it may be the parameters used in the module (exposed in my presentation) or a combination of modules in a particular order (I attached the XMP of the trace) but the problem persists. I will do more tests to see how far I can go to find out what is going on. I think I can clone the image with the operations performed on it and experiment from there without risk of losing subsequent changes to that module, which I want to keep. Thank you |
|
You really don't have to beg for my understanding :-) 1. Not having earlier issues just means i did not get hands on any log file. 2. Missing your darktable opencl settings (can read that from your log if provided) 3. No idea where exactly your system fails 4. No idea if your OpenCl is ready and good or if you are using a bad driver (there have been a number of issues with amd rusticl drivers and while working on dt we have found at least two bugs there ...) So please don't insist on "it's that module" .. let's see what the logs show to investigate/proceed further. Also would need to know - is this only on OpenCL or also on GPU ? EDIT: could you provide the complete original xmp file you have been using? |
|
Thanks for giving me an interesting hint, which I've been digging into for several hours. You mentioned that it could be related to "bad drivers", so I decided to do some more tests. First, I checked that I had (I don't know why) all drivers enabled in DT, and only ROCm should be enabled. Then, I checked that I couldn't use openCL, for reasons unknown to me. After some research, I managed to get openCL working on my operating system (clinfo.txt) and Then, I enabled its use in DT and restarted it. I did the export again, and got the same wrong result when exporting. And the output using I should add that I had hoped that in mathematical export processes in complex formats such as JXL, more intensive use would be made of the GPU with openCL, but it is barely used in 10% of the process. It is the CPU that is practically at 100% 80% of the time in that export. I don't know if this is normal or depends on other factors. Any additional information needed, please ask me for it. |
darktable doesn’t reimplement any output formats that use compression, but re-uses existing implementations (because if one would have wanted to implement JXL compression on GPU, it would have made more sense to create a separate library for that, and then use it in darktable). Do you know of any open-source (or even any at all) JXL encoder libraries that run on GPU? |
Well, I have taken the trouble to check the current status of this possibility with the official libraries and it only exists as a "feature request", but nothing else, and I really don't understand why, since JXL is one of the formats that requires more calculations to achieve compression. We will surely have to wait several years ... |
|
The provided log shows two cl platforms which it probably not correct and might the reason for the issue. don't know how you did that but that is very likely an installation problem of the cl system. |
|
I don't know if you mean that it shows "OpenCL 2.5" and "OpenCL 3.0" in two different places in the output of " |
|
It shows two drivers for one card in the darktable log. That's clearly not ok. |
|
@RafaelLinux I reported a similar issue here #17239 |
|
Sorry it took me so long to respond. I swear I started writing the reply many days ago and something happened that I didn't get around to sending it. rocminfo output is: |
|
This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue. |
|
Even after upgrade to a most recent ROCm version, same issue. |
|
I'm using a slightly more outdated AMD GPU (RX 5700 XT) and have no (more) problems with stripes in images. Here is my clinfo output: which looks a lot like yours. I assume you're also using the latest AMD driver version 24.20.3? Here is my rocminfo: rocminfo.txt You omitted the first part, "mROCk module version" and "HSA System Attributes". Did you make sure that darktable is only allowed to use the Rocm opencl engine instead of rusticl and others? |
|
This is my Not sure about my AMD Driver And you can see I have only enabled ROCm in Darktable. And I'm using SLES drivers in Tumbleweed. And, as I commented, Davinci Resolve works w/o issues with this config. |
|
Not sure about your config still. From your earlier log: This part looks clearly wrong Also your clinfo log (you only provided the first part) should show only one platform. Don't know about davinci and how that checks for cl devices. maybe they do better - and dt might do better - but having multiple platforms (likely you have multiple driver versions installed) for a single graphics card is not correct afaik. |
In my case I'm using amdgpu-install version 6.2.60203, but this shouldn't be the issue as you reported flawless operation with other tools utilizing OpenCL, such das davinci resolve. When I execute I find it strange that darktable recognizes two devices in your output, although |
It's not strange as his log shows there are two platforms as mentioned above. So the one hardware device is initialized on two platforms resulting in two available devices which is clearly wrong and leading to issues. This almost always is the result of a bad installation or having used "dirty" tricks to make "it running". We have seen this before especially on "arch" based distributions ... So what to do?
|
|
@RafaelLinux I suspect that this issue is related to the ones described here (although smaller AMD iGPUs are involved):
tl;dr: open your darktable config file ( |
|
You are absolutely right. After applying the change you detailed, those color bands no longer appear in any export format. I even got the impression that the export in JXL is faster than before. So thank you very much. Will this patch be automatically implemented in future versions of DarkTable, or if I reinstall the operating system, will I have to make the change again? |
|
@RafaelLinux @da-phil Please open a new issue like "Suggestion to use pinned mode for AMD shared devices" and discuss that there ... |
|
After doing several tests, I can add the following:
Now I will open the thread you mentioned. Again, thank you for looking for a solution to the problem. I was stuck not being able to export to JXL, and it was not easy to find a solution (the ones provided did not work). |
Describe the bug
After making changes to an image with DT and proceeding to export, the exported image has vertical stripes only on the right side of the image, regardless of the output format (either uncompressed TIFF or uncompressed JXL).
In order to test what could be the problem, I deactivated modules in that image, and I discovered that by deactivating the "Contrast Equalizer" module, the problem disappears.
Steps to reproduce
Expected behavior
Export image as in screen, without vertical stripes
Logfile | Screenshot | Screencast
Commit
No response
Where did you obtain darktable from?
downloaded from www.darktable.org
darktable version
4.6.1
What OS are you using?
Linux
What is the version of your OS?
openSUSE Tumbleweed
Describe your system?
Operating System: openSUSE Tumbleweed 20240611
KDE Plasma Version: 6.0.5
KDE Frameworks Version: 6.3.0
Qt Version: 6.7.1
Kernel Version: 6.9.3-1-default (64-bit)
Graphics Platform: Wayland
Processors: 24 × AMD Ryzen 9 3900X 12-Core Processor
Memory: 31.3 GiB of RAM
Graphics Processor: AMD Radeon RX 7600
Product Name: B550M Phantom Gaming 4
Are you using OpenCL GPU in darktable?
I dont know
If yes, what is the GPU card and driver?
No response
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
<x:xmpmeta xmlns:x="adobe:ns:meta/" x:xmptk="XMP Core 4.4.0-Exiv2">
<rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#">
<rdf:Description rdf:about=""
xmlns:exif="http://ns.adobe.com/exif/1.0/"
xmlns:xmp="http://ns.adobe.com/xap/1.0/"
xmlns:xmpMM="http://ns.adobe.com/xap/1.0/mm/"
xmlns:darktable="http://darktable.sf.net/"
exif:DateTimeOriginal="2024:06:03 03:13:07.000"
xmp:Rating="1"
xmpMM:DerivedFrom="Lado brasileño 20a_upscayl_4x_realesrgan-x4plus.webp"
darktable:import_timestamp="63852981790338624"
darktable:change_timestamp="63852984959695977"
darktable:export_timestamp="63853868874731244"
darktable:print_timestamp="-1"
darktable:xmp_version="5"
darktable:raw_params="0"
darktable:auto_presets_applied="1"
darktable:history_end="19"
darktable:iop_order_version="3"
darktable:history_basic_hash="8921fe8edb66aeacff411f85c52c8f4a"
darktable:history_current_hash="8c61e22fda30c0d309c59ffcfb3fc540">
darktable:masks_history
rdf:Seq/
</darktable:masks_history>
darktable:history
rdf:Seq
<rdf:li
darktable:num="0"
darktable:operation="colorin"
darktable:enabled="1"
darktable:modversion="7"
darktable:params="gz48eJxjZBgFowABWAbaAaNgwAEAEDgABg=="
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz11eJxjYIAACQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dcF/IADRAGpyHQU="/>
<rdf:li
darktable:num="1"
darktable:operation="colorout"
darktable:enabled="1"
darktable:modversion="5"
darktable:params="gz35eJxjZBgFo4CBAQAEEAAC"
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz11eJxjYIAACQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dcF/IADRAGpyHQU="/>
<rdf:li
darktable:num="2"
darktable:operation="gamma"
darktable:enabled="1"
darktable:modversion="1"
darktable:params="0000000000000000"
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz11eJxjYIAACQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dcF/IADRAGpyHQU="/>
<rdf:li
darktable:num="3"
darktable:operation="flip"
darktable:enabled="1"
darktable:modversion="2"
darktable:params="ffffffff"
darktable:multi_name="auto"
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz11eJxjYIAACQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dcF/IADRAGpyHQU="/>
<rdf:li
darktable:num="4"
darktable:operation="exposure"
darktable:enabled="0"
darktable:modversion="6"
darktable:params="00000000000000000000000000004842000080c000000000"
darktable:multi_name="basado en la escena (predefinido)"
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz08eJxjYGBgYAFiCQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dlAx68oBEMbFxwX+AwGIBgCbGCeh"/>
<rdf:li
darktable:num="5"
darktable:operation="graduatednd"
darktable:enabled="0"
darktable:modversion="1"
darktable:params="0000803f0000000000000000000048420000000000000000"
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz08eJxjYGBgYAFiCQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dlAx68oBEMbFxwX+AwGIBgCbGCeh"/>
<rdf:li
darktable:num="6"
darktable:operation="retouch"
darktable:enabled="0"
darktable:modversion="3"
darktable:params="gz99eJztyyERACEARcE/Z6hBFGhOBCIhOMUgCLBrnnoJAAAAAAAAAAAAAAAA8Oo7mrTxt+3WfvtmSRZ7mgK9"
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz08eJxjYGBgYAFiCQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dlAx68oBEMbFxwX+AwGIBgCbGCeh"/>
<rdf:li
darktable:num="7"
darktable:operation="cacorrectrgb"
darktable:enabled="1"
darktable:modversion="1"
darktable:params="01000000af477d41c3f508400000000000000000"
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz08eJxjYGBgYAFiCQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dlAx68oBEMbFxwX+AwGIBgCbGCeh"/>
<rdf:li
darktable:num="8"
darktable:operation="channelmixerrgb"
darktable:enabled="0"
darktable:modversion="3"
darktable:params="gz05eJxjYGiwZ8AAxIpRBpiAmAWKf9WtsgNhhog5riC7GKHyALHsCQM="
darktable:multi_name="scene-referred default"
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz08eJxjYGBgYAFiCQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dlAx68oBEMbFxwX+AwGIBgCbGCeh"/>
<rdf:li
darktable:num="9"
darktable:operation="sharpen"
darktable:enabled="0"
darktable:modversion="1"
darktable:params="cdccfc3f5ebac93f8195a741"
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz10eJxjYGBgYAJiCQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dcF/IADRAG2yHQc="/>
<rdf:li
darktable:num="10"
darktable:operation="lens"
darktable:enabled="0"
darktable:modversion="10"
darktable:params="gz10eJxjZGBgYGeAgQZ7BhRQ5cLIMAogABQ2uDBMHg7soRgMAAWKB/0="
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz11eJxjYIAACQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dcF/IADRAGpyHQU="/>
<rdf:li
darktable:num="11"
darktable:operation="diffuse"
darktable:enabled="0"
darktable:modversion="2"
darktable:params="18000000000000003d00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002f000000"
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz08eJxjYGBgYAFiCQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dlAx68oBEMbFxwX+AwGIBgCbGCeh"/>
<rdf:li
darktable:num="12"
darktable:operation="atrous"
darktable:enabled="1"
darktable:modversion="2"
darktable:params="gz03eJxjZoCAs2d87M6eOWM3a6akPZBtz8DQYE9r8RRnHvsNFrr2ZUr69nFOovZe04rsbReU2uf9Y7S/pc9kf0GX0f5vPIN9WwiTfaQsg737vf92Pqm/7YR2/rdbGPrfbvbW93ZuAf/tGEgGDfYATlpKng=="
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz10eJxjYGBgYAJiCQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dcF/IADRAG2yHQc="/>
<rdf:li
darktable:num="13"
darktable:operation="denoiseprofile"
darktable:enabled="0"
darktable:modversion="11"
darktable:params="gz06eJxjYGBwYGB4AMQN9nYbm+wV1E/tmzlzpt3ZM2dsQWLi2y9awDADEmCE0qtXadmtXrXKDsi0B7LtQ0ND7UH6BpnckMCM0HCFYQAS2Uqh"
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz08eJxjYGBgYAFiCQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dlAx68oBEMbFxwX+AwGIBgCbGCeh"/>
<rdf:li
darktable:num="14"
darktable:operation="filmicrgb"
darktable:enabled="0"
darktable:modversion="6"
darktable:params="gz02eJybNXOyIwMDw0EGhgYHBjBwANInnCAYAmYB1egvq7ABiV1JanXguq4MZDfYw+TPnvGxYwbSLEDMCBVjRGLDABOUBgA4gBDg"
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz08eJxjYGBgYAFiCQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dlAx68oBEMbFxwX+AwGIBgCbGCeh"/>
<rdf:li
darktable:num="15"
darktable:operation="toneequal"
darktable:enabled="0"
darktable:modversion="2"
darktable:params="cc720a3d2776fc3d19456c3deb62e23cead5153d663e88bd49955ebe7be699bdb653693d0000a040f304b53f0000803f000000000000000000000000040000000400000001000000"
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz08eJxjYGBgYAFiCQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dlAx68oBEMbFxwX+AwGIBgCbGCeh"/>
<rdf:li
darktable:num="16"
darktable:operation="highlights"
darktable:enabled="0"
darktable:modversion="4"
darktable:params="000000000000803f00000000000000009cc4c03f000000001e00000006000000cdcccc3e000000400000000000000000"
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz11eJxjYGBgYARiCQYYOOHEgAZY0QWgejBBgz0Ej1Q+dcF/IADRAGwSHQY="/>
<rdf:li
darktable:num="17"
darktable:operation="bilat"
darktable:enabled="1"
darktable:modversion="3"
darktable:params="010000000000003f0000003f0000803e0000003f"
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz10eJxjYGBgYAJiCQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dcF/IADRAG2yHQc="/>
<rdf:li
darktable:num="18"
darktable:operation="colorzones"
darktable:enabled="1"
darktable:modversion="5"
darktable:params="gz09eJxjYgCBBjsgYS+vssnu1bs8e733DPaHz/jYMzA42IPEGQYcQNw3eNyDDga3+1iAmAmKGZEwDIDYABhaDG4="
darktable:multi_name=""
darktable:multi_name_hand_edited="0"
darktable:multi_priority="0"
darktable:blendop_version="13"
darktable:blendop_params="gz10eJxjYGBgYAJiCQYYOOHEgAZY0QWAgBGLGANDgz0Ej1Q+dcF/IADRAG2yHQc="/>
</rdf:Seq>
</darktable:history>
</rdf:Description>
</rdf:RDF>
</x:xmpmeta>
The text was updated successfully, but these errors were encountered: