8000 Consider `EXTRANEOUS_MODIFIER` diagnostic improvements · Issue #55814 · dart-lang/sdk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Consider EXTRANEOUS_MODIFIER diagnostic improvements #55814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pq opened this issue May 22, 2024 · 0 comments
Open

Consider EXTRANEOUS_MODIFIER diagnostic improvements #55814

pq opened this issue May 22, 2024 · 0 comments
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. model-parser Parser issues in the analyzer/CFE P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member
pq commented May 22, 2024

In https://dart-review.googlesource.com/c/sdk/+/367540, I removed a bunch of unused diagnostics that are hold-overs from the analyzer's parser. They're dead so removing them is the right thing to do but the messages they provided are arguably better than the more generic shared one produced by the EXTRANEOUS_MODIFIER catch-all produced by the shared parser.

This issue is a place-holder if we decide to revisit.

/fyi @stereotype441 @bwilkerson
@pq pq added legacy-area-analyzer Use area-devexp instead. P3 A lower priority bug or feature request legacy-area-front-end Legacy: Use area-dart-model instead. fe-analyzer-shared-parser labels May 22, 2024
@johnniwinther johnniwinther added the cfe-messages Poor/undesirable messaging in errors/warnings emitted by the CFE. label May 23, 2024
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label May 24, 2024
@bwilkerson bwilkerson added area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. and removed legacy-area-analyzer Use area-devexp instead. legacy-area-front-end Legacy: Use area-dart-model instead. cfe-messages Poor/undesirable messaging in errors/warnings emitted by the CFE. labels Feb 28, 2025
@johnniwinther johnniwinther added model-parser Parser issues in the analyzer/CFE and removed fe-analyzer-shared-parser labels Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. model-parser Parser issues in the analyzer/CFE P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pq @srawlins @bwilkerson @johnniwinther
0