8000 Added Measurement Faker by Tahanima · Pull Request #194 · datafaker-net/datafaker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added Measurement Faker #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2022
Merged

Added Measurement Faker #194

merged 1 commit into from
May 30, 2022

Conversation

Tahanima
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link
codecov-commenter commented May 30, 2022 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (380d21f) to head (da89e97).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #194      +/-   ##
============================================
- Coverage     94.81%   94.77%   -0.04%     
- Complexity     1787     1796       +9     
============================================
  Files           181      182       +1     
  Lines          3781     3793      +12     
  Branches        377      377              
============================================
+ Hits           3585     3595      +10     
- Misses          102      103       +1     
- Partials         94       95       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tahanima
Copy link
Contributor Author

@bodiam, net.datafaker.PhoneNumberTest.testAllCellPhone_enUS test is failing.

@bodiam
Copy link
Contributor
bodiam commented May 30, 2022

@Tahanima yeah, seems like we still have a flaky tests here somewhere. Your PR looks good though, so lets just merge it, the us phone number we'll fix later! Thanks again!

@bodiam bodiam merged commit 474401f into datafaker-net:master May 30, 2022
@Tahanima Tahanima deleted the feature/add-measurement-faker branch May 30, 2022 14:21
@Tahanima
Copy link
Contributor Author

@Tahanima yeah, seems like we still have a flaky tests here somewhere. Your PR looks good though, so lets just merge it, the us phone number we'll fix later! Thanks again!

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tahanima @codecov-commenter @bodiam
0