Running tests on NixOS #832
Replies: 3 comments 4 replies
-
|
Sounds like some good progress :) If you'd like me to take a look, would you like to add |
Beta Was this translation helpful? Give feedback.
-
|
Hello! I don't know anything about Docker, and I have zero clue if this is the idiomatic way to make a nix dockerfile, but this works for me and lets me reproduce the issue (on main, after applying the patch from #831):
{
pkgs ? import <nixpkgs> { },
}:
pkgs.mkShell {
nativeBuildInputs = [
# Write a wrapper for GCC that passes -B to *unwrapped* binutils.
# This ensures that if -fuse-ld=bfd is used, gcc picks up unwrapped ld.bfd
# instead of the hardcoded wrapper search directory.
# We pass it last because apparently gcc likes picking ld from the *first* -B,
# which we want our wild target directory to be if passed.
(pkgs.writeShellApplication {
name = "gcc";
text = ''${pkgs.lib.getExe pkgs.gcc} "$@" -B${pkgs.binutils-unwrapped-all-targets}/bin '';
})
(pkgs.writeShellApplication {
name = "g++";
text = ''${pkgs.lib.getExe' pkgs.gcc "g++"} "$@" -B${pkgs.binutils-unwrapped-all-targets}/bin '';
})
pkgs.binutils-unwrapped-all-targets
pkgs.llvmPackages_20.clang
pkgs.lld
pkgs.glibc.out
pkgs.glibc.static
pkgs.rustup
];
LD_LIBRARY_PATH = "${pkgs.stdenv.cc.cc.lib}/lib";
}
# Run inside a Nix shell.
#
# docker build --progress=plain -t wild-dev-nix . -f docker/nix.Dockerfile
#
# docker run -it wild-dev-nix nix-shell
FROM nixos/nix AS chef
COPY shell.nix shell.nix
RUN nix-shell --run "rustup toolchain install nightly && cargo install --locked cargo-chef"
WORKDIR /wild
FROM chef as planner
COPY . .
RUN nix-shell --run "cargo chef prepare --recipe-path recipe.json"
FROM chef AS builder
COPY --from=planner /wild/recipe.json recipe.json
COPY shell.nix shell.nix
RUN nix-shell --run "cargo chef cook --all-targets --recipe-path recipe.json"
COPY . .Then, I could reproduce by running: docker build --progress=plain -t wild-dev-nix . -f docker/nix.Dockerfile
docker run -it wild-dev-nix nix-shell
cargo test # in the nix shell that you should be dropped into |
Beta Was this translation helpful? Give feedback.
-
|
Thanks! I can confirm that I'm able to reproduce the failure with that. If you felt inclined to send those files as a PR, I'd be happy to merge them. Alternatively, I'm also happy to make a PR provided you're happy for that to happen with an MIT+Apache2 license. |
Beta Was this translation helpful? Give feedback.
-
|
Sure, take whatever you want from my shell |
Beta Was this translation helpful? Give feedback.
-
|
I've got a proposed fix for the segfault - #843 I looked also at the failure of libc_integration, which was failing for the config Wild converted the TLS access to local exec, wheas GNU ld only converted to initial exec. This is interesting, because on my laptop, which has a substantially older version of GNU ld, it performs the same optimisation as we do (local exec). One thing that I sometimes do in cases like this is to enable linking with lld in the test. liker-diff will then accept what wild does, so long as it matches either GNU ld or lld. I made that change in #844 |
Beta Was this translation helpful? Give feedback.
-
|
I wired up Wild so you can use it like any other linker with Nix. I'll make a draft nixpkgs PR that is blocked on 0.6.0 (and 1.87 in nixpkgs) for here in a moment. Has tests that build GNU Hello with Clang & GCC. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
NixOS is not known for being friendly to linkers. In has tons of hacks and gcc and ld wrappers to make it work. As such, tests don't execute easily.
I've been trying to get wild tests to run successfully on NixOS.
I'll collect findings here.
So far I have, after a lot of experimentation, written up this
shell.nix:With #831 applied, all tests except two pass:
For
tlsdesc.c, the binary segfaults with wild (but not with BFD). I haven't investiated that failure.libc-integration.cfails to link the binary withldandclang-static, which indicates missing glibc static binaries.Adding
buildInputs = [ pkgs.glibc.out pkgs.glibc.static ];to the shell causes new failures though (some assembly relocation diff).Beta Was this translation helpful? Give feedback.
All reactions