8000 Build is failing on some architectures · Issue #74 · davisp/jiffy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Build is failing on some architectures #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rbalint opened this issue Nov 12, 2014 · 9 comments
Closed

Build is failing on some architectures #74

rbalint opened this issue Nov 12, 2014 · 9 comments

Comments

@rbalint
Copy link
rbalint commented Nov 12, 2014

I have packaged latest release (0.13.2) in Debian, but it does not build on several architectures:
https://buildd.debian.org/status/package.php?p=erlang-jiffy&suite=experimental

Arm64 is simply disabled:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764500

Others are failing due to this test failing:
...
jiffy_01_yajl_tests:16: gen (string_invalid_escape)...ok
jiffy_01_yajl_tests:16: gen (string_invalid_hex_char)...failed
in function jiffy_01_yajl_tests:'-gen/1-fun-0-'/2 (test/jiffy_01_yajl_tests.erl, line 16)
**error:{assertException_failed,
[{module,jiffy_01_yajl_tests},
{line,16},
{expression,"jiffy : decode ( Json )"},
{pattern,"{ throw , Erl , [...] }"},
jiffy_01_yajl_tests:18: gen (string_with_escapes)...ok
...
@davisp
Copy link
Owner
davisp commented Nov 12, 2014

For Arm64 that's due to the double-conversion library [1] apparently not supporting that architecture. I don't change their compiler detection directly but if you can convince them to change it for that platform I'd pull any upstream changes.

For that bad hex string test is there a resource I can access to debug on any of the particular architectures that fail? If I had to guess its an endian issue but I don't have immediate access to a big-endian machine to check directly.

@davisp
Copy link
Owner
davisp commented Nov 12, 2014

Oops, double-conversion is here:

https://github.com/floitsch/double-conversion

@rbalint rbalint mentioned this issue Nov 12, 2014
Closed
@rbalint
Copy link
Author
rbalint commented Nov 12, 2014

There is are several machines available for Free Software developers at https://gcc.gnu.org/wiki/CompileFarm if you would like to reproduce the problem.
If you use Debian you can also use Qemu to emulate the build on a target machine:
https://wiki.debian.org/QemuUserEmulation

@davisp davisp closed this as completed in 137d3d9 Nov 13, 2014
@davisp
Copy link
Owner
davisp commented Nov 13, 2014

@rbalint The 0.13.3 tag should be the fix for the platforms that had failing test suites. Let me know if it fixes everything for you.

@rbalint
Copy link
Author
rbalint commented Nov 13, 2014

Thanks! I'll upload it to Debian in a few days. I would like to wait the few days to see if the arm64 problem gets fixed in doubleconversion.

@davisp
Copy link
Owner
davisp commented Nov 13, 2014

No problem. If it does let me know and I'll refresh that dependency.

On Thu, Nov 13, 2014 at 2:04 AM, Balint Reczey notifications@github.com
wrote:

Thanks! I'll upload it to Debian in a few days. I would like to wait the
few days to see if the arm64 problem gets fixed in doubleconversion.

—
Reply to this email directly or view it on GitHub
#74 (comment).

@rbalint
Copy link
Author
rbalint commented Nov 30, 2014

double-conversion problem is fixed now
google/double-conversion@cb2beeb

@davisp
Copy link
Owner
davisp commented Dec 1, 2014

Awesome. I'll work on getting that pulled in for you.

@rbalint
Copy link
Author
rbalint commented Jun 1, 2015

OK, I'll happily update the Debian package when this gets fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davisp @rbalint
0