8000 Completion improvements · Issue #11 · dbuenzli/down · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Completion improvements #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dbuenzli opened this issue Jul 22, 2019 · 5 comments
Open

Completion improvements #11

dbuenzli opened this issue Jul 22, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@dbuenzli
Copy link
Owner
dbuenzli commented Jul 22, 2019 •
edited
Loading

As mentioned in the manual completion support is rather crude at the moment.

Here are a few directions that could be taken:

  1. Patch #directory directives via Topdirs to collect which directories are included and pass corresponding -I arguments to ocp-index. This doesn't however allow us to determine which modules are opened and we miss those -I option that may have been specified on the ocaml invocation. Best for this would be to solve point 2. in this issue upstream as this would have benefits for other projects aswell (ocamlfind, utop, omod).

  2. Along with working on the various points in Improve the toplevel API ocaml/ocaml#7589, try to convince merlin authors to provide support for toplevel sessions via the cli. @pqwy mentioned almost getting to something with ocamlmerlin single complete-prefix, but that "it falls short because it heavily assumes you are editing a file in a project".

In general it seems better to isolate completion via the cli and try to improve the Toploop API so that compiler-libs is not needed (also using compiler-libs in ocamlnat is a no-go). This allows down to work for the rest (readline, history, sessions) even though the underlying completion engine may not have been updated for the latest version of the compiler.
@dbuenzli dbuenzli added the enhancement New feature or request label Jul 22, 2019
@dbuenzli dbuenzli mentioned this issue Jul 29, 2019
Open
@ghost
Copy link
ghost commented Aug 21, 2019

I was thinking as well that it would be nice to use merlin in utop for completion. I remember talking briefly about it with @let-def once. IIRC, we concluded that there was no fundamental blocker.

@dbuenzli dbuenzli mentioned this issue Nov 1, 2020
Open
6 tasks
@dbuenzli dbuenzli mentioned this issue Nov 22, 2023
Closed
@nojb
Copy link
Contributor
nojb commented May 8, 2024

This is somewhat orthogonal to the ideas in this issue, but I recently played with reimplementing completion using compiler-libs: nojb@4c7d77f (it is a proof of concept, so not complete and a little rough around the edges).

Upsides:

  • No dependency on any other tool
  • Faster than invoking an external tool
  • Makes use of the current environment (opens, local variables, etc)

Downsides:

  • Depends on compiler-libs (=> one need to build a non-expunged toplevel) (*)
  • For documentation, either the .cmis need to have been produced with -keep-docs or one needs to use .cmt files (not done in the proof of concept)

(*) is probably a blocker for an external project such as this, but it would disappear if this code was ever upstreamed into OCaml itself :)

Cheers!

@dbuenzli
Copy link
Owner Author
dbuenzli commented May 8, 2024
  • Depends on compiler-libs (=> one need to build a non-expunged toplevel) (*)

I would love for the expunge process to go. I can appreciate and understand its idea but since we need to improve ocaml outside of the system it has rather lead to code I would have liked not to have written. However as I noted there it's not necessarily about compiler libs but providing the right bits in Toploop.

The other problem is that AFAIR loading compiler-libs in ocamlnat is a no-go. Not sure if something has changed on that front since them.

@dbuenzli
Copy link
Owner Author
dbuenzli commented May 9, 2024

A propos @nojb if these things are in the ocaml executable anyways it may be possible to expose bits from upstream in the Toploop API. Even if not used by ocaml itself, this can be benificial for other contexts (e.g. js_of_ocaml topevels).

@dbuenzli
Copy link
Owner Author
dbuenzli commented May 9, 2024

The other problem is that AFAIR loading compiler-libs in ocamlnat is a no-go. Not sure if something has changed on that front since them.

But it seems ocamlnat is not expunged:

> ocamlnat
OCaml version 4.14.2 - native toplevel
Enter #help;; for help.

Down v0.3.0-7-ge3a4f38 loaded. Type Down.help () for more info.
Omod v0.0.4-3-gb0d2684 loaded. Type Omod.help () for more info.
# Config.version;;
- : string = "4.14.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nojb @dbuenzli
0