10000 Move tasks into separate folder and fix JSCS/JSHint by tbranyen · Pull Request #48 · f/delorean · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move tasks into separate folder and fix JSCS/JSHint #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2014
Merged

Move tasks into separate folder and fix JSCS/JSHint #48

merged 2 commits into from
Nov 6, 2014

Conversation

tbranyen
Copy link
Contributor
@tbranyen tbranyen commented Nov 6, 2014
  • Migrate Grunt tasks into separate files for better maintainability.
  • Fix JSCS and JSHint errors.

@tbranyen tbranyen changed the title WIP: Break out Gruntfile into separate distinct tasks WIP: Some improvements Nov 6, 2014
@tbranyen tbranyen mentioned this pull request Nov 6, 2014
Open
7 tasks
@tbranyen
Copy link
Contributor Author
tbranyen commented Nov 6, 2014

Moved my checklist into a separate issue: #49

@tbranyen tbranyen changed the title WIP: Some improvements Migrate Grunt tasks into separate folder and fix JSCS/JSHint Nov 6, 2014
@tbranyen tbranyen changed the title Migrate Grunt tasks into separate folder and fix JSCS/JSHint Move tasks into separate folder and fix JSCS/JSHint Nov 6, 2014
f pushed a commit that referenced this pull request Nov 6, 2014
Merge pull request #48 from tbranyen/some-improvements
3bd325a 
Move tasks into separate folder and fix JSCS/JSHint
@f f merged commit 3bd325a into f:master Nov 6, 2014
@darcyadams
Copy link
Collaborator

anyone opposed to moving grunt config files to coffee-script? Grunt supports it natively, and it makes the configs so much cleaner and easier to read... nothing more annoying that forgetting a comma or closing brace in JSON.

@tbranyen
Copy link
Contributor Author
tbranyen commented Nov 6, 2014

@darcyadams http://tbranyen.com/post/coffeescript-has-the-ideal-syntax-for-configurations

You know I don't :D, I've been using CoffeeScript with Grunt configs for a while and I love them.

Check out: https://github.com/tbranyen/combyne/tree/master/build/tasks sooo much cleaner

@darcyadams
Copy link
Collaborator

@tbranyen haha, awesome. Yeah, once I figured out grunt supports cs, I never looked back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbranyen @darcyadams @f
0