8000 Bug Report: Some SVGs contain strokes in them · Issue #788 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Bug Report: Some SVGs contain strokes in them #788
Closed
@Thomas-Boi

Description

@Thomas-Boi

Bug

Short description of the bug that you found. Provide images/code if applicable.
Some SVGs contain strokes in them, which will get ignored when Icomoon process them into icons. The SVGs are:

  • clojurescript-plain
  • matlab-line
  • threejs-original
  • threejs-original-wordmark

Note that the clojurescript and matlab had already been built. Thus, we will need to open a proper PR that will update these icons.

On a side note: the open-gl entry in the devicon.json also contained an improper aliases attribute. This causes the script to skip the open-gl SVG in the build process.

How to replicate the bug

Examine the SVGs listed above and search for stroke-width. You should see that these attributes are present in the SVGs. You can also upload the SVGs to Icomoon and see the warning message.

Possible Fixes/Solutions

Convert these SVGs so they use fills instead. The solution is listed in Icomoon FAQ. As for the open-gl issue, a simple deletion of that attribute is sufficient.

Metadata

Metadata

Assignees

Labels

bugUse this label for pointing out bugs

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0