From f1052713234bc167a9c2c32a400c5c5e1f58041c Mon Sep 17 00:00:00 2001 From: Thomas Bui Date: Fri, 25 Jun 2021 23:05:00 -0700 Subject: [PATCH 01/15] Create a general pull_request_template.md --- .../PULL_REQUEST_TEMPLATE/new_feature.md | 10 +++- .../PULL_REQUEST_TEMPLATE/new_icon.md | 6 ++- .github/drafts/pull_request_template.md | 46 +++++++++++++++++++ 3 files changed, 59 insertions(+), 3 deletions(-) rename .github/{ => drafts}/PULL_REQUEST_TEMPLATE/new_feature.md (52%) rename .github/{ => drafts}/PULL_REQUEST_TEMPLATE/new_icon.md (83%) create mode 100644 .github/drafts/pull_request_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE/new_feature.md b/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md similarity index 52% rename from .github/PULL_REQUEST_TEMPLATE/new_feature.md rename to .github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md index 22a6c7ba2..dd3dd50bd 100644 --- a/.github/PULL_REQUEST_TEMPLATE/new_feature.md +++ b/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md @@ -7,7 +7,13 @@ assignees: '' --- -## This PR adds... +## Double check these details before you open a PR** +*Tick the checkboxes to ensure you've done everything* +- [] PR does not match another non-stale PR currently opened +- [] PR name matches the format *New Feature: brief description of feature* + + +## This PR adds/fixes... *List your features here and the benefits they bring.* @@ -15,3 +21,5 @@ assignees: '' *List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc....).* *Don't forget to link any issues that this PR will solved.* + +**Please link any issue that this PR should solve if it's applicable** diff --git a/.github/PULL_REQUEST_TEMPLATE/new_icon.md b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md similarity index 83% rename from .github/PULL_REQUEST_TEMPLATE/new_icon.md rename to .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md index 81cbeada2..6d420ca62 100644 --- a/.github/PULL_REQUEST_TEMPLATE/new_icon.md +++ b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md @@ -7,7 +7,7 @@ assignees: '' --- -**Double check these details before you open a PR** +## Double check these details before you open a PR** *Tick the checkboxes to ensure you've done everything* - [] PR does not match another non-stale PR currently opened - [] PR name matches the format *new icon: Icon name (versions separated by comma)* as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview) @@ -18,5 +18,7 @@ assignees: '' Refer to the [`CONTRIBUTING.md`](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) for more details. -**Link to the official page to prove your SVG is correct and up to date.** +## Link to the official page to prove your SVG is correct and up to date. *Link goes here* + +**Please link any issue that this PR should solve if it's applicable** \ No newline at end of file diff --git a/.github/drafts/pull_request_template.md b/.github/drafts/pull_request_template.md new file mode 100644 index 000000000..e62564ca8 --- /dev/null +++ b/.github/drafts/pull_request_template.md @@ -0,0 +1,46 @@ +--- +name: Pull Request Template +about: Add a new icon or feature to the repo. +title: 'New Icon/Feature: [NAME]' +assignees: '' + +--- +# New Icon Section +If you are adding a new icon, delete the **New Feature** section down below and follow the steps listed here. + +## Double check these details before you open a PR** +*Tick the checkboxes to ensure you've done everything* +- [] PR does not match another non-stale PR currently opened +- [] PR name matches the format *new icon: Icon name (versions separated by comma)* as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview) +- [] Your icons are put in a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines) +- [] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards) +- [] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-) + +Refer to the [`CONTRIBUTING.md`](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) for more details. + + +## Link to the official page to prove your SVG is correct and up to date. +*Link goes here* + +**Please link an issue that this PR should solve if it's applicable** + + +# New Feature Section +If you are adding a new icon, delete the **New Icon** section up above and follow the steps listed here. + +## Double check these details before you open a PR** +*Tick the checkboxes to ensure you've done everything* +- [] PR does not match another non-stale PR currently opened +- [] PR name matches the format *New Feature: brief description of feature* + + +## This PR adds/fixes... + +*List your features here and the benefits they bring.* + +## Notes + +*List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc....).* +*Don't forget to link any issues that this PR will solved.* + +**Please link any issue that this PR should solve if it's applicable** From e3f38d38a72a7011bab8a084757da14722bb667d Mon Sep 17 00:00:00 2001 From: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Date: Sun, 27 Jun 2021 15:51:59 -0700 Subject: [PATCH 02/15] Apply suggestions from code review Co-authored-by: David Leal --- .../PULL_REQUEST_TEMPLATE/new_feature.md | 2 +- .github/drafts/pull_request_template.md | 19 +++++++++++-------- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md b/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md index dd3dd50bd..b3524170e 100644 --- a/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md +++ b/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md @@ -8,7 +8,7 @@ assignees: '' --- ## Double check these details before you open a PR** -*Tick the checkboxes to ensure you've done everything* +*Tick the checkboxes to ensure you've done everything correctly* - [] PR does not match another non-stale PR currently opened - [] PR name matches the format *New Feature: brief description of feature* diff --git a/.github/drafts/pull_request_template.md b/.github/drafts/pull_request_template.md index e62564ca8..052480a8c 100644 --- a/.github/drafts/pull_request_template.md +++ b/.github/drafts/pull_request_template.md @@ -6,30 +6,33 @@ assignees: '' --- # New Icon Section -If you are adding a new icon, delete the **New Feature** section down below and follow the steps listed here. + +If you are adding a new icon, delete the **New Feature** section below, and follow the steps listed there. ## Double check these details before you open a PR** -*Tick the checkboxes to ensure you've done everything* + +*Tick the checkboxes to ensure you've done everything correctly* - [] PR does not match another non-stale PR currently opened - [] PR name matches the format *new icon: Icon name (versions separated by comma)* as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview) -- [] Your icons are put in a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines) +- [] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines) - [] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards) - [] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-) -Refer to the [`CONTRIBUTING.md`](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) for more details. +Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. -## Link to the official page to prove your SVG is correct and up to date. +## Link to the official page to prove your SVG is correct and up-to-date. *Link goes here* **Please link an issue that this PR should solve if it's applicable** - # New Feature Section -If you are adding a new icon, delete the **New Icon** section up above and follow the steps listed here. + +If you are adding a new icon, delete the **New Icon** section up above, and follow the steps listed there. ## Double check these details before you open a PR** -*Tick the checkboxes to ensure you've done everything* + +*Tick the checkboxes to ensure you've done everything correctly* - [] PR does not match another non-stale PR currently opened - [] PR name matches the format *New Feature: brief description of feature* From af1b3b57ff63df8da1c56c8796e59f22e58a5ca9 Mon Sep 17 00:00:00 2001 From: Thomas Bui Date: Sun, 27 Jun 2021 16:17:18 -0700 Subject: [PATCH 03/15] Add line about base of PR in pr template --- .github/drafts/pull_request_template.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/drafts/pull_request_template.md b/.github/drafts/pull_request_template.md index 052480a8c..41fbb2b42 100644 --- a/.github/drafts/pull_request_template.md +++ b/.github/drafts/pull_request_template.md @@ -7,13 +7,14 @@ assignees: '' --- # New Icon Section -If you are adding a new icon, delete the **New Feature** section below, and follow the steps listed there. +If you are adding a new icon, follow the steps listed here, and delete the **New Feature** section below. ## Double check these details before you open a PR** *Tick the checkboxes to ensure you've done everything correctly* - [] PR does not match another non-stale PR currently opened -- [] PR name matches the format *new icon: Icon name (versions separated by comma)* as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview) +- [] PR name matches the format *new icon: Icon name (versions separated by comma)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview) +- [] PR's base is the `develop` branch. - [] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines) - [] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards) - [] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-) @@ -28,7 +29,7 @@ Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CON # New Feature Section -If you are adding a new icon, delete the **New Icon** section up above, and follow the steps listed there. +If you are adding a new icon, follow the steps listed here, and delete the **New Icon** section above. ## Double check these details before you open a PR** From 602e47fad6e4b147d9bee666aaf5f7d3e4f98c22 Mon Sep 17 00:00:00 2001 From: Thomas Bui Date: Sun, 4 Jul 2021 18:13:51 -0700 Subject: [PATCH 04/15] Update PR and Issue templates --- .github/ISSUE_TEMPLATE/bug_report.md | 6 ++--- .github/ISSUE_TEMPLATE/feature_request.md | 6 ++--- .github/ISSUE_TEMPLATE/icon-request.md | 5 ++-- .../PULL_REQUEST_TEMPLATE/new_feature.md | 11 ++++---- .../drafts/PULL_REQUEST_TEMPLATE/new_icon.md | 18 ++++++------- .github/{drafts => }/pull_request_template.md | 26 ++++++++----------- 6 files changed, 33 insertions(+), 39 deletions(-) rename .github/{drafts => }/pull_request_template.md (53%) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index e3dc4e054..c3159bc1d 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -8,10 +8,10 @@ assignees: '' --- ### Bug -*Short description of the bug that you found. Provide images/code if applicable.* + ### How to replicate the bug -*What should we do to replicate this bug.* + ### Possible Fixes/Solutions -*List any possible fixes/suggestions that you have in mind that could solve this issue.* + diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 7439bf1f1..89509eb34 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -8,10 +8,10 @@ assignees: '' --- ### Problem -*Tell us about the current problem that you face that this feature might help you with.* + ### Suggested Feature -*Short description of the feature.* + ### Why we should have this feature -*List any extra benefits, other than solving your problem, that this feature will bring to the repo. If none, leave blank.* + diff --git a/.github/ISSUE_TEMPLATE/icon-request.md b/.github/ISSUE_TEMPLATE/icon-request.md index 1b575a915..58b2d7106 100644 --- a/.github/ISSUE_TEMPLATE/icon-request.md +++ b/.github/ISSUE_TEMPLATE/icon-request.md @@ -4,11 +4,10 @@ about: Requesting a new icon or changes to an existing icon title: 'Icon request: [NAME]' labels: 'request:icon' assignees: '' - --- ### About the icon -*Short description of why you think this icon belongs in our project.* + ### Links -*Provide links to the icon's official website/repository. Anywhere that shows us what the technology is about and its official logo. If available, also provide some resources (SVG's) where the icon can be found (Font Awesome, Icomoon, etc..).* + diff --git a/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md b/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md index b3524170e..b78c8fa85 100644 --- a/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md +++ b/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md @@ -6,20 +6,19 @@ labels: 'enhancement' assignees: '' --- + ## Double check these details before you open a PR** -*Tick the checkboxes to ensure you've done everything correctly* + + - [] PR does not match another non-stale PR currently opened - [] PR name matches the format *New Feature: brief description of feature* ## This PR adds/fixes... -*List your features here and the benefits they bring.* + ## Notes -*List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc....).* -*Don't forget to link any issues that this PR will solved.* - -**Please link any issue that this PR should solve if it's applicable** + diff --git a/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md index 6d420ca62..1d35ac393 100644 --- a/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md +++ b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md @@ -6,19 +6,19 @@ labels: 'feature:icon' assignees: '' --- + +## Double check these details before you open a PR -## Double check these details before you open a PR** -*Tick the checkboxes to ensure you've done everything* + - [] PR does not match another non-stale PR currently opened -- [] PR name matches the format *new icon: Icon name (versions separated by comma)* as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview) -- [] Your icons are put in a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines) +- [] PR name matches the format *new icon: Icon name (versions separated by comma)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview) +- [] PR's base is the `develop` branch. +- [] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines) - [] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards) - [] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-) -Refer to the [`CONTRIBUTING.md`](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) for more details. + -## Link to the official page to prove your SVG is correct and up to date. -*Link goes here* - -**Please link any issue that this PR should solve if it's applicable** \ No newline at end of file +## Link to prove your SVG is correct and up-to-date. + diff --git a/.github/drafts/pull_request_template.md b/.github/pull_request_template.md similarity index 53% rename from .github/drafts/pull_request_template.md rename to .github/pull_request_template.md index 41fbb2b42..7c8280b72 100644 --- a/.github/drafts/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,11 +7,11 @@ assignees: '' --- # New Icon Section -If you are adding a new icon, follow the steps listed here, and delete the **New Feature** section below. + -## Double check these details before you open a PR** +## Double check these details before you open a PR -*Tick the checkboxes to ensure you've done everything correctly* + - [] PR does not match another non-stale PR currently opened - [] PR name matches the format *new icon: Icon name (versions separated by comma)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview) - [] PR's base is the `develop` branch. @@ -19,32 +19,28 @@ If you are adding a new icon, follow the steps listed here, and delete the **New - [] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards) - [] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-) -Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. - + -## Link to the official page to prove your SVG is correct and up-to-date. -*Link goes here* -**Please link an issue that this PR should solve if it's applicable** +## Link to prove your SVG is correct and up-to-date. + +--- # New Feature Section -If you are adding a new icon, follow the steps listed here, and delete the **New Icon** section above. + ## Double check these details before you open a PR** -*Tick the checkboxes to ensure you've done everything correctly* + - [] PR does not match another non-stale PR currently opened - [] PR name matches the format *New Feature: brief description of feature* ## This PR adds/fixes... -*List your features here and the benefits they bring.* + ## Notes -*List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc....).* -*Don't forget to link any issues that this PR will solved.* - -**Please link any issue that this PR should solve if it's applicable** + From 7c8660818226ffa5b6e0f045d166af4c2f8c48ad Mon Sep 17 00:00:00 2001 From: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Date: Mon, 5 Jul 2021 11:13:36 -0700 Subject: [PATCH 05/15] Update .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md Co-authored-by: David Leal --- .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md index 1d35ac393..7ae056e40 100644 --- a/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md +++ b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md @@ -19,6 +19,5 @@ assignees: '' - ## Link to prove your SVG is correct and up-to-date. From 31c3d72238547fd3a06bb157d189478be4cef258 Mon Sep 17 00:00:00 2001 From: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Date: Mon, 5 Jul 2021 16:52:45 -0700 Subject: [PATCH 06/15] Update .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md Good idea Co-authored-by: David Leal --- .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md index 7ae056e40..a2b7bc5ce 100644 --- a/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md +++ b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md @@ -1,7 +1,7 @@ --- name: New Icon about: Add a new icon to the repo. -title: 'New Icon: [NAME] (versions)' +title: 'new Icon: [NAME] (versions)' labels: 'feature:icon' assignees: '' From ec6c64132363d05951d68a9330f0b230312de98b Mon Sep 17 00:00:00 2001 From: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Date: Mon, 5 Jul 2021 17:43:30 -0700 Subject: [PATCH 07/15] Update .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md Co-authored-by: David Leal --- .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md index a2b7bc5ce..61c0c1395 100644 --- a/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md +++ b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md @@ -1,6 +1,6 @@ --- name: New Icon -about: Add a new icon to the repo. +about: Add a new icon to the repository. title: 'new Icon: [NAME] (versions)' labels: 'feature:icon' assignees: '' From 18e49c7e79dfbbe387ceb43bf90717f454a2cb16 Mon Sep 17 00:00:00 2001 From: David Leal Date: Mon, 5 Jul 2021 19:50:48 -0500 Subject: [PATCH 08/15] Apply suggestions from code review --- .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md index 61c0c1395..7b2637b33 100644 --- a/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md +++ b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md @@ -20,4 +20,4 @@ assignees: '' ## Link to prove your SVG is correct and up-to-date. - + From c797fdb555fa68e2d764c792bcc1be50b3d29c62 Mon Sep 17 00:00:00 2001 From: David Leal Date: Mon, 5 Jul 2021 19:53:00 -0500 Subject: [PATCH 09/15] Apply suggestions from code review --- .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md index 7b2637b33..57f046f78 100644 --- a/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md +++ b/.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md @@ -1,7 +1,7 @@ --- name: New Icon about: Add a new icon to the repository. -title: 'new Icon: [NAME] (versions)' +title: 'new icon: [NAME] (versions)' labels: 'feature:icon' assignees: '' From 51f79c40ac7b44bbd72e2dd7f52b7dd89ed3d3cd Mon Sep 17 00:00:00 2001 From: David Leal Date: Mon, 5 Jul 2021 20:02:57 -0500 Subject: [PATCH 10/15] Apply suggestions from code review --- .github/ISSUE_TEMPLATE/feature_request.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 89509eb34..0bca52fed 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -14,4 +14,4 @@ assignees: '' ### Why we should have this feature - + From 73f5fbecba260e102b88658127a783501137a1b2 Mon Sep 17 00:00:00 2001 From: David Leal Date: Mon, 5 Jul 2021 20:09:01 -0500 Subject: [PATCH 11/15] Apply suggestions from code review --- .github/ISSUE_TEMPLATE/icon-request.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/icon-request.md b/.github/ISSUE_TEMPLATE/icon-request.md index 58b2d7106..3592bf26a 100644 --- a/.github/ISSUE_TEMPLATE/icon-request.md +++ b/.github/ISSUE_TEMPLATE/icon-request.md @@ -10,4 +10,4 @@ assignees: '' ### Links - + From 4dffbf7ac03a60b84d1abb97fb3e01b66d8ba720 Mon Sep 17 00:00:00 2001 From: David Leal Date: Mon, 5 Jul 2021 20:11:20 -0500 Subject: [PATCH 12/15] Apply suggestions from code review --- .github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md b/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md index b78c8fa85..2dc712b29 100644 --- a/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md +++ b/.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md @@ -21,4 +21,4 @@ assignees: '' ## Notes - + From b90699973021b2064653d7c2c0f2d7f9770427c8 Mon Sep 17 00:00:00 2001 From: David Leal Date: Mon, 5 Jul 2021 20:17:24 -0500 Subject: [PATCH 13/15] Apply suggestions from code review --- .github/pull_request_template.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 7c8280b72..ec93637c5 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -21,7 +21,6 @@ assignees: '' - ## Link to prove your SVG is correct and up-to-date. From 7ea77dc87c960e951efff8998ebde68469e18165 Mon Sep 17 00:00:00 2001 From: David Leal Date: Mon, 5 Jul 2021 20:20:32 -0500 Subject: [PATCH 14/15] Apply suggestions from code review --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ec93637c5..c3cb1af61 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -22,7 +22,7 @@ assignees: '' ## Link to prove your SVG is correct and up-to-date. - + --- # New Feature Section From 41f857ffab45f03da4c28288ca1fb187296f1515 Mon Sep 17 00:00:00 2001 From: David Leal Date: Mon, 5 Jul 2021 20:24:14 -0500 Subject: [PATCH 15/15] Apply suggestions from code review --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index c3cb1af61..8d993a368 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -42,4 +42,4 @@ assignees: '' ## Notes - +