Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My work going through military units
This started when I noticed the mess that is the heavy and light cavalry lines, with stuff like first strike immunities and flanking atack capabilities bouncing back and forth between them. Then I noticed stuff with ships, and some more things here and there, and have tweaked everything until my mind is a bit more at peace.
So, from the beginning of the XML, downwards, more or less:
(BTW, with Globalism beelined, Marines could be made without Ballistics. There are also a few units which likely use high caliber guns that could be made without it, like the Tank, Cruiser, or Battleship. Not sure if that's worth correcting for realism's sake)
The Cavalry is here AF5F :
It seems there was a bit of confusion from the beginning, since Chariot has both Horseman and Horse Archer in two separated unit upgrade blocks.
The way I've set it up, the Light Cavalry line is the one that gets the first strike immunity, open terrain attack, and Siege Weapon combat bonus and flanking. The Heavy Cavalry line only has its raw strength and mobility to work with.
Back to non cavalry:
And now the Navy:
There is now a "Transport" line with the... transport ships, separated from a "Warship" line with most of the other ships. With a few UU exceptions, otherwise the upgrade lines were making too many weird jumps and changes in function for my tastes
And the finale
This is an awful lot, take what you will or don't, hopefully something catches your attention
Of course there would also be parts of the pedia and pedia strategy texts that ought to be updated, but that's hardly worth it IMO