8000 Issue in the code · Issue #199 · dhorions/boxable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Issue in the code #199
Open
Open
@alexey-levande

Description

@alexey-levande

Hello everyone,

I'm solving an issue in my app for building tables in PDF and found strange code in the method DrawRow of the Table class. Please look on the code snippet:

	// if it is not header row or first row in the table then remove row's
		// top border
		if (row != header && row != rows.get(0)) {
			if (!isEndOfPage(row)) {
				row.removeTopBorders();
			}
		}

here is the row variable compared to header. I'm not so deep in java, but they have different types - row is Row and header is List. Could you please double check that it is correct?

I assumed that this comparison can be removed at all - so top borders can be removed if this row is not first and it is not EndOfPage.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0