8000 OTEL errors are not logged through Logrus · Issue #4275 · distribution/distribution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

OTEL errors are not logged through Logrus #4275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
corhere opened this issue Feb 5, 2024 · 1 comment · Fixed by #4292
Closed

OTEL errors are not logged through Logrus #4275

corhere opened this issue Feb 5, 2024 · 1 comment · Fixed by #4292
Assignees
@gotgelf

Comments

@corhere
Copy link
Collaborator
corhere commented Feb 5, 2024

Description

The OpenTelemetry SDK by default handles "irredeemable" errors by logging then to stderr using the stdlib log package. We are neglecting to override this default, so OTEL logs are formatted differently from all other application logs.

Reproduce

See #4270

Expected behavior

OTEL errors are logged in the same format as any other application error

registry version

v3.0.0-alpha.1

Additional Info

https://pkg.go.dev/go.opentelemetry.io/otel#SetErrorHandler
@corhere corhere mentioned this issue Feb 5, 2024
Open
@gotgelf
Copy link
Contributor
gotgelf commented Feb 5, 2024

Hi @corhere , @milosgajdos , i would like to work on this one, can you please assign it to me?

@gotgelf gotgelf mentioned this issue Feb 9, 2024
Merged
@gotgelf gotgelf mentioned this issue Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gotgelf gotgelf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Standardize OTEL error logging format to match application logs gotgelf/distribution
2 participants
@corhere @gotgelf
0