Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 8 commits
- 5 files changed
- 5 contributors
Commits on Aug 31, 2023
-
remove deprecated SplitHostname
It was deprecated since distribution [v2.7.0-rc.0][1] [1]: distribution/distribution@9a43b8f Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Commits on Sep 1, 2023
Commits on Sep 2, 2023
-
refactor splitDockerDomain to include more documentation
The splitDockerDomain attempts to determine whether the given name contains a domain, or should be used as a "remote-name". The logic used in doing so is based on (legacy) conventions, which have not always been properly documented. The logic used in this function was also optimized for "brevity", but not easy to ready, due to the combination of multiple boolean conditions combined on a single line, and some "double negatives". More documentation may still be needed, but let's start with documenting the logic used in this function; - Use `strings.Cut()` instead of `strings.IndexRune()`, which allows us to use descriptive variable names, and prevents use of the magic `-1` value. - Split the conditions into a switch, so that each of them can be documented separately. While this makes the code more verbose (and introduces some duplication), it should not impact performance, as only one condition would ever be met (performance may even be better, as the old code combined multiple conditions with `&&`). - Introduce a fast-path for single-element ("familiar") names. These names can be canonicalized early, without doing further handling. While working on the code, I also discovered an existing bug (or omission) where the code would not handle bare _domain names_. Ironically, the TestParseDockerRef test has a test-case name "hostname only", but which does not cover that case. THat test-case was transferred from containerd/cri, and does not describe this scenario (possibly was left as a "further exercise"); containerd/cri@25fdf72 Let keep it as a further exercise, but add a "TODO" to remind us doing so. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Commits on Feb 14, 2024
-
Exclude domain from name length check
Signed-off-by: Ozair <ozair.asim@docker.com>
Commits on Mar 20, 2024
-
Signed-off-by: Christoph Mewes <christoph@kubermatic.com>
-
-
Merge pull request #9 from ozairasim/exclude-domain-from-name-length-…
…validation Exclude domain from name length check
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.5.0...v0.6.0