spl_object_hash() vs spl_object_id()

BC Break Report

Q	A
BC Break	yes
Version	2.10

Summary

After #8837, there are some UoW methods that the parameter has changed:

orm/lib/Doctrine/ORM/UnitOfWork.php

Lines 3243 to 3254 in 81d472f

    
               /** 
        
                * INTERNAL: 
        
                * Clears the property changeset of the entity with the given OID. 
        
                * 
        
                * @param int $oid The entity's OID. 
        
                * 
        
                * @return void 
        
                */ 
        
               public function clearEntityChangeSet($oid) 
        
               { 
        
                   unset($this->entityChangeSets[$oid]); 
        
               }

orm/lib/Doctrine/ORM/UnitOfWork.php

Lines 3025 to 3040 in 81d472f

    
               /** 
        
                * INTERNAL: 
        
                * Sets a property value of the original data array of an entity. 
        
                * 
        
                * @param int    $oid 
        
                * @param string $property 
        
                * @param mixed  $value 
        
                * 
        
                * @return void 
        
                * 
        
                * @ignore 
        
                */ 
        
               public function setOriginalEntityProperty($oid, $property, $value) 
        
               { 
        
                   $this->originalEntityData[$oid][$property] = $value; 
        
               }

Because the OID is different, at first I thought they were internal, but apparently it is some kind of internal notes.

Previous behavior

Before this, for calling these method you should generate the oid with spl_object_hash()

Current behavior

Now that oid is not valid anymore.

How to reproduce

Tests started to fail in https://github.com/doctrine-extensions/DoctrineExtensions

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

BC Break Report

Summary

Previous behavior

Current behavior

How to reproduce

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	/**
	* INTERNAL:
	* Clears the property changeset of the entity with the given OID.
	*
	* @param int $oid The entity's OID.
	*
	* @return void
	*/
	public function clearEntityChangeSet($oid)
	{
	unset($this->entityChangeSets[$oid]);
	}

	/**
	* INTERNAL:
	* Sets a property value of the original data array of an entity.
	*
	* @param int $oid
	* @param string $property
	* @param mixed $value
	*
	* @return void
	*
	* @ignore
	*/
	public function setOriginalEntityProperty($oid, $property, $value)
	{
	$this->originalEntityData[$oid][$property] = $value;
	}

Description

BC Break Report

Summary

Previous behavior

Current behavior

How to reproduce

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions