8000 Feature: Add summary title by micmarc · Pull Request #568 · dorny/test-reporter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature: Add summary title #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 17, 2025
Merged

Conversation

micmarc
Copy link
Contributor
@micmarc micmarc commented Mar 27, 2025

Add new option report-title to add H1 title to the Markdown report

Resolves #540

@jozefizso jozefizso self-assigned this Mar 27, 2025
@jozefizso jozefizso added the enhancement New feature or request label Mar 27, 2025
@jozefizso jozefizso self-requested a review March 27, 2025 17:06
@micmarc
Copy link
Contributor Author
micmarc commented Mar 27, 2025

@jozefizso Please confirm the desired behavior when report-title is left blank. If you prefer, we can omit the title (legacy behavior) vs. using a default.

I can also add the rest of the tests once the above is decided.

@jozefizso
Copy link
Collaborator

Hi @micmarc, thanks for this feature, I think it is very useful.

I would say let's omit the title altogether so people can keep existing behavior when the title is not set (empty).

@micmarc micmarc force-pushed the feature/summary-title branch from 3ea2146 to 998cd3a Compare March 28, 2025 21:12
@micmarc micmarc marked this pull request as ready for review March 29, 2025 01:28
@micmarc
Copy link
Contributor Author
micmarc commented Mar 29, 2025

Hi @micmarc, thanks for this feature, I think it is very useful.

I would say let's omit the title altogether so people can keep existing behavior when the title is not set (empty).

@jozefizso Updated and ready for review.

@jozefizso jozefizso force-pushed the feature/summary-title branch from b78a9a0 to f1fa471 Compare May 17, 2025 11:38
@jozefizso jozefizso merged commit 29aefa7 into dorny:main May 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify action summary title
2 participants
0