8000 Comparing actions:main...dscho:main · actions/checkout · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: actions/checkout
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: dscho/checkout
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 17 commits
  • 1 file changed
  • 1 contributor

Commits on Mar 3, 2023

  1. TEST 

    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    5ea9f4c View commit details
    Browse the repository at this point in the history

  2. TEST: disable all logic, but load all code 

    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    5e1f37e View commit details
    Browse the repository at this point in the history

  3. TEST: remove code of the main module 

    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    62175eb View commit details
    Browse the repository at this point in the history

  4. TEST: reinstate main module's code 

    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    993d596 View commit details
    Browse the repository at this point in the history

  5. TEST: remove just the run/cleanup functions 

    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    1ceafec View commit details
    Browse the repository at this point in the history

  6. TEST: remove just some imports 

    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    e9e679f View commit details
    Browse the repository at this point in the history

  7. TEST: remove all but one import 

    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    7a3b320 View commit details
    Browse the repository at this point in the history

  8. TEST: import coreCommand again, as the unexplained load time dropped … 

    …dramatically

There is a noticeable delay in `actions/checkout@v3` after this line:

	▶ Run dscho/checkout@main

The delay is diagnosed by instrumenting the compiled Action: instead of
starting the core logic we throw an exception.

With an only lightly instrumented version, we see an almost two minute
long delay after that line:
https://github.com/dscho/git-for-windows-automation/actions/runs/4321187056/jobs/7542820362#step:2:49

Removing some imports at first did not change that, but when removing
all but the first import, the delay dropped to two seconds:
https://github.com/dscho/git-for-windows-automation/actions/runs/4321187056/jobs/7545290126#step:2:49

Let's see whether loading `coreCommand` is what causes that surprising
difference.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    b32ed14 View commit details
    Browse the repository at this point in the history

  9. TEST: is it the sourceProvider??? 

    Whodunnit? Who causes that slow-down? It might be the sourceProvider.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    62872f8 View commit details
    Browse the repository at this point in the history

  10. TEST: Is it _really_ the gitSourceProvider? 

    The slow-down is back:
https://github.com/dscho/git-for-windows-automation/actions/runs/4321187056/jobs/7545872938#step:2:49

But what about those other two imports?

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    5486524 View commit details
    Browse the repository at this point in the history

  11. MOAR-INSTRUMENTATION 

    This commit _litters_ the code with `console.log()` statements. Ah! The
good old times are back. Printf debugging for the win, because what else
works?

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    17598e2 View commit details
    Browse the repository at this point in the history

  12. EVEN MOAR INSTRUMENTATION 

    Aha! Toggling timestamps at
https://github.com/dscho/git-for-windows-automation/actions/runs/4321187056/jobs/7546198761#step:2:606
reveals that module 562 (`universalUserAgent`) was loaded, and then a
minute was spent _somewhere_ and then the module 385 (`endpoint`)
finished loading.

Looks as if something in that `endpoint` is not going all too well.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    19e4ea1 View commit details
    Browse the repository at this point in the history

  13. Instrument with a non-buffering print statement 

    `console.log()` uses `stdout`, which buffers, therefore the timestamps
do not correspond to the actual time of call. D'oh. Let's use `stderr`
instead.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    e6eb7e2 View commit details
    Browse the repository at this point in the history

  14. Do instrument windowsRelease() 

    Local testing suggests that this might be called _quite_ a couple of
times and is costly (because it spawns a full-fledged process).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    a38d513 View commit details
    Browse the repository at this point in the history

  15. TEST: prefer wmic over powershell 

    This imitates
https://github.com/sindresorhus/windows-release/pull/18/files

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    f730898 View commit details
    Browse the repository at this point in the history

  16. Revert to origin/main 

    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    757cbb1 View commit details
    Browse the repository at this point in the history

  17. TEST: prefer wmic over powershell 

    This imitates
https://github.com/sindresorhus/windows-release/pull/18/files

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    07e7f97 View commit details
    Browse the repository at this point in the history
Loading
0