8000 New Component: Media Container 2.2 · Issue #44 · eBay/evo-web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

New Component: Media Container 2.2 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
6 tasks
soniamacias opened this issue Mar 27, 2025 · 1 comment
Open
6 tasks

New Component: Media Container 2.2 #44

soniamacias opened this issue Mar 27, 2025 · 1 comment
Labels
design system Requested by the design system package: skin

Comments

@soniamacias
Copy link
soniamacias commented Mar 27, 2025 •
edited
Loading

Description

Request to create a new component called Media Container based on the existing file-preview-card, which will include options for customizable icons, set aspect ratios, and scrims. The current file-preview-card will be kept until the next major version.

  • As a user, I can customize the icon.
  • As a user, I can disable the icon from displaying.
  • As a user, I can choose still and animated graphics, images, videos, GIFs, 3D assets, and Rive animations.
  • As a user, I can choose the following set aspect ratios: 1:1, 2:3, 4:5, and 16:9.

Additional mentions for when media container plays video:

  • Video plays in line.
  • Video controls to utilize existing video player specs
  • Open question: Can build support a ~2 second preview on hover scroll? Are there accessibility concerns?

See https://playbook.ebay.com/design-system/components/media-container for more details.

Version: 2.2

Screenshots

No response

Figma link

https://www.figma.com/design/jFbAR0o364WhsjELfxl2SI/Playbook-2.0-%2F-Components?m=auto&node-id=207-147092&t=uADFkcucD3gVeEn4-1

Engineering pre-requisites

  • Successful design review with Design System Team.
  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
  • Successful accessibility review with Core A11Y Team.
  • Successful frontend review with eBayUI Team.
@soniamacias soniamacias added design system Requested by the design system needs triage labels Mar 27, 2025
@github-project-automation github-project-automation bot moved this to Todo in eBayUI Mar 27, 2025
@soniamacias soniamacias changed the title New Component: Media Container New Component: Media Container 2.2 Mar 27, 2025
@agliga agliga transferred this issue from eBay/skin Apr 25, 2025
@soniamacias
Copy link
Author

@agliga @ArtBlue Ticket has been updated to reflect what we discussed in today's meeting w/Randy. Here are the action items for Design Systems:

  1. Rebuild Media Container component in Figma.
  2. Update Playbook documentation to reflect icon option and video player specs (native video player controls, web video player controls, inline playback).

We'll aim to have everything ready for June. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design system Requested by the design system package: skin
Projects
eBayUI
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agliga @soniamacias
0