10000 Comparing davidtheclark:master...ebsco:master · davidtheclark/react-aria-menubutton · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: davidtheclark/react-aria-menubutton
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ebsco/react-aria-menubutton
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 11 files changed
  • 2 contributors

Commits on Oct 5, 2016

  1. Expose focusItem method to be used outside library.

    @LeopoldoFu
    LeopoldoFu committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    9b61bdf View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2016

  1. Add unit test for externalStateControl.focusItem(). 

    Fix externalStateControl.focusItem so it correctly uses the index passed in.
    @LeopoldoFu
    LeopoldoFu committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    727e594 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from ebsco/expose-focus-item 

    Expose focus item
    @LeopoldoFu
    LeopoldoFu authored Oct 6, 2016
    Configuration menu
    Copy the full SHA
    c2d4234 View commit details
    Browse the repository at this point in the history

  3. 4.2.0

    @LeopoldoFu
    LeopoldoFu committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    826141b View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2016

  1. Always focus on first menu item when menu is opened.

    @LeopoldoFu
    LeopoldoFu committed Oct 10, 2016
    Configuration menu
    Copy the full SHA
    b44f032 View commit details
    Browse the repository at this point in the history

  2. Update readme and demo to reflect that first menu item is focused aut… 

    …omatically when opened as per wai-aria practices guide.
    @LeopoldoFu
    LeopoldoFu committed Oct 10, 2016
    Configuration menu
    Copy the full SHA
    7ba150f View commit details
    Browse the repository at this point in the history

  3. Update existing tests to reflect following change: first menu item is… 

    … always automatically focused when menu is opened.
    @LeopoldoFu
    LeopoldoFu committed Oct 10, 2016
    Configuration menu
    Copy the full SHA
    acb3bf8 View commit details
    Browse the repository at this point in the history

  4. Fix menu button click test. All tests green.

    @LeopoldoFu
    LeopoldoFu committed Oct 10, 2016
    Configuration menu
    Copy the full SHA
    549bcb4 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2016

  1. Merge pull request #2 from ebsco/focus-first-item-menu-open 

    Focus first item menu open
    @LeopoldoFu
    LeopoldoFu authored Oct 11, 2016
    Configuration menu
    Copy the full SHA
    dd050e1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master'

    @LeopoldoFu
    LeopoldoFu committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    033b77a View commit details
    Browse the repository at this point in the history

  3. 5.0.0

    @LeopoldoFu
    LeopoldoFu committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    1fd5c8e View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2016

  1. Actually toggle menu open/close when activating menu button; it was a… 

    …lways only opening.

Fix tests.
    @LeopoldoFu
    LeopoldoFu committed Oct 13, 2016
    Configuration menu
    Copy the full SHA
    8c2f508 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from ebsco/toggle-menu-instead-of-always-open 

    Actually toggle menu open/close when activating menu button; it was a…
    @LeopoldoFu
    LeopoldoFu authored Oct 13, 2016
    Configuration menu
    Copy the full SHA
    d42b948 View commit details
    Browse the repository at this point in the history

  3. 5.0.1

    @LeopoldoFu
    LeopoldoFu committed Oct 13, 2016
    Configuration menu
    Copy the full SHA
    6125978 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2016

  1. Expose focus method to focus on menu button element.

    @LeopoldoFu
    LeopoldoFu committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    c2e6a63 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4 from ebsco/expose-menu-button-focus-method 

    Expose focus method to focus on menu button element.
    @LeopoldoFu
    LeopoldoFu authored Oct 24, 2016
    Configuration menu
    Copy the full SHA
    7853d97 View commit details
    Browse the repository at this point in the history

  3. 5.1.0

    @LeopoldoFu
    LeopoldoFu committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    26c0985 View commit details
    Browse the repository at this point in the history
Loading
0