Description
rowHeightsOptions.autoBelowLineCount
functionality stems from a feature request: #7835. It has been introduced on #8096. It's in beta status to verify whether it contains performance issues or other bugs (see discussion in #7835 and various bug reports around auto height grids). The purpose of this task is to track the beta feature, analyze the usage and group improvements to the functionality to assure its usability and stability.
Important
This beta status can be removed if Discover is able to use this feature extensively in production without major user issues for an extended period of time.
Feature description
rowHeightsOptions.autoBelowLineCount
feature flag enables custom lineCount
behavior, where lineCount
acts like a max number of lines instead of a set number of lines for all rows.
Usage notes
There is no usage in the whole Kibana repository.
Discover
Discover doesn't use rowHeightsOptions.autoBelowLineCount
at the moment because it doesn't cover the full extent of the required functionality.
EuiDataGrid usage: src/platform/packages/shared/kbn-unified-data-table/src/components/data_table.tsx
Custom row heights options hook: src/platform/packages/shared/kbn-unified-data-table/src/hooks/use_row_heights_options.ts
Custom row height count hook: src/platform/packages/shared/kbn-unified-data-table/src/hooks/use_row_height.ts
Custom toolbar: src/platform/packages/shared/kbn-unified-data-table/src/components/data_table_additional_display_settings.tsx
(usage in the first file, line 1035 renderCustomToolbarFn
)
Goal
As part of this ticket we should analyze the differences between the current implementation and functionality scope and the desired functionality scope. We can analyze the differences between our implementation and Discover team implementation. Additionally, we should plan tasks to arrive at a feature parity and assure functional stability and fair usage.