10000 Simplify `esrally/config.py` module. · Issue #1920 · elastic/rally · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Simplify esrally/config.py module. #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fressi-elastic opened this issue Mar 3, 2025 · 0 comments
Open

Simplify esrally/config.py module. #1920

fressi-elastic opened this issue Mar 3, 2025 · 0 comments

Comments

@fressi-elastic
Copy link
Contributor
fressi-elastic commented Mar 3, 2025 •
edited
Loading

Unnecessary code complexity has been spotted in esrally/config.py module:

  • There is a separate module esrally/types.py defining typing hints for it. This makes code hard to follow because of the need to include both modules (types and config) with types two types (types.Config and config.Config) referring to exactly the same thing where the protocol is not always in sync with its implementation.
  • The implementation of the key retrieval makes often use of the full content iteration because storing value scope data as keys instead of values. Despite making keys insertion simpler, it is affected later by a much more complex retrieval approach. The scope should instead be stored as a value, not as a key.
  • There is a sort of cyclic dependency between modules dependency involving config.py and paths.py that should be resolved.
  • Testing for esrally/config.py is using a dummy lower level component that is not implementing exaclty the methods of the implementation class it replaces. This has been spotted while passing linters verifications when adding typing hints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fressi-elastic
0