workspace command: inline a private function to an anonymous one #437

NJichev · 2024-04-24T16:50:24Z

A workspace command that inlines a private function

Example:

defmodule Example do
  def run(list) do
    Enum.map(list, &square/1)
  end

  defp square(x) do
    x * x
  end
end

Hovering square in the run function should and using the workspace command should result in:

defmodule Example do
  def run(list) do
    square = fn x -> x * x end
    Enum.map(list, square)
  end
end

Consider the following scenarios:

Any function calls to square(3) should be converted to their anonymous counterpart: square.(3)

The text was updated successfully, but these errors were encountered:

mhanberg · 2024-04-24T17:58:00Z

@NJichev i think that my expectation for this sort of refactor would be to actually inline the function with a lambda at the call sites.

so you example of

defmodule Example do
  def run(list) do
    Enum.map(list, &square/1)
  end

  defp square(x) do
    x * x
  end
end

would refactor to

defmodule Example do
  def run(list) do
    Enum.map(list, fn x -> x * x end)
  end
end

NJichev added enhancement New feature or request workspace-command labels Apr 24, 2024

NJichev changed the title ~~workspace command: inline a private function~~ workspace command: inline a private function to an anonymous one Apr 24, 2024

NJichev added the good first issue Good for newcomers label Apr 24, 2024

mhanberg mentioned this issue Apr 24, 2024

workspace command: extract an anonymous function to a private one #436

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

workspace command: inline a private function to an anonymous one #437

workspace command: inline a private function to an anonymous one #437

Uh oh!

Uh oh!

workspace command: inline a private function to an anonymous one #437

workspace command: inline a private function to an anonymous one #437

Comments

Uh oh!