8000 Librato reporter gets 400 errors from Librato if it has no data to send · Issue #42 · eric/metriks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content < 8000 link crossorigin="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/keyboard-shortcuts-dialog.f8fba3bd67fe74f9227b.module.css" />
Librato reporter gets 400 errors from Librato if it has no data to send #42
Open
@myronmarston

Description

@myronmarston

In our system, the activity of our job queues is very bursty: every day around midnight, millions of jobs are enqueued and processed, and then there are times later in the day where there is no work to do. We've been getting a bunch of 400 errors from Librato with an error like this:

 {"errors":{"request":["Must contain a measurement"]}}

Looking at the Metriks librato reporter this makes sense: it submits all measurements that were taken in the last minute regardless of whether or not there were any. When there were none, it gets the 400 error from Librato.

It would be nice if the Metriks librato reporter was a bit smarter about this and would not try to submit a request with no metrics.

@eric, if you're on board with that idea I'll try to make time to submit a PR for this in the next week or so.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0