10000 ESParser: enable all Babylon plugins by default for next version of ESDoc. · Issue #345 · esdoc/esdoc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
ESParser: enable all Babylon plugins by default for next version of ESDoc. #345
Closed
@typhonrt

Description

@typhonrt

@h13i32maru I just took a glance around the mainline code and saw that ESParser can be improved. For comparison please review the version of ESParser in my fork.

In particular what I am concerned about is not enabling all Babylon plugins by default. There is no downside as far as I'm aware to enabling all plugins. There is also no reason to require the user to provide a config parameter experimentalProposal to enable just the classProperties plugin. To my knowledge there is only additional AST generated by the plugins and no detrimental effects for ESDoc processing when all are enabled by default. It's important for instance to have the flow plugin enabled so that AST processing by ESDoc plugins can pick up the additional Flow nodes even if ESDoc itself doesn't yet support Flow. So please consider enabling all Babylon plugins available by default.

A secondary concern is locking Babylon option sourceType to module. Please take a look how I use a regex to determine if a file is using ES6 module format and select between module or script accordingly.

I'm certainly fine if you are interested in taking my version of ESParser over the current version.

Also please update the ETA on v1.0 of ESDoc as things are seemingly stalling again.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0