8000 Aparrent conflict with BetterRoleColor · Issue #36 · estroBiologist/pluralchum · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Aparrent conflict with BetterRoleColor #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
paratulip opened this issue Oct 12, 2023 · 3 comments
Open

Aparrent conflict with BetterRoleColor #36

paratulip opened this issue Oct 12, 2023 · 3 comments

Comments

@paratulip
Copy link

Enabling both BetterRoleColors by Zerebos and this plugin results proxy'd text appearing as white, rather than the color of the proxy's set user color. Only this plugin, ZeresPluginLibrary, and BetterRoleColors are enabled. Including configs for all three plugins for hopeful ease of replication.

Pluralchum.config.json
ZeresPluginLibrary.config.json
BetterRoleColors.config.json
@SnowboundCabin
Copy link
SnowboundCabin commented Dec 2, 2023 •
edited
Loading

this can be fixed by adding + " !important" to the color property in the function setMessageTextColour. BRC will attempt to do its thing, but unless also set to use !important, pluralchum's will be treated as important and used. I added it on line 23881 and that fixed regular text, although it seems like it also broke headers. adding it on 23886 as well breaks all proxy recoloring, though, even though it seems reasonable looking at just that function.
BRC should ignore webhooks, as they never have a role attached, but doesn't - maybe an issue should be raised to BRC's dev?
Thank you for mentioning this - I was wondering why the latest update said it fixed the proxy text when it still wasn't working for me, and knowing what was causing the issue was enough to get myself a hacky fix until the developer has time/energy to fix it.

@ariagivens
Copy link
Collaborator

I couldn't replicate the issue with the latest versions of Pluralchum and BetterRoleColors. Can you confirm if it's still an issue?

@SnowboundCabin
Copy link
SnowboundCabin commented Apr 26, 2024 •
edited
Loading

Yes, on Pluralchum 2.2.0 and BRC 0.10.2 (both latest as of writing) there is still an issue, although it's that with PC enabled, BRC will not recolor non-PK message text. This seems to happen regardless of whether BRC is set to !important or not.
(Apologies for the slow reply.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SnowboundCabin @paratulip @ariagivens
0