8000 Change type of Value prop · Issue #123 · fable-compiler/fable-react · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Change type of Value prop #123
Closed
Closed
@alfonsogarciacaro

Description

@alfonsogarciacaro

When using a select element that has Multiple true property, React forces us to pass a string array as Value, however this prop is currently typed as Value of string, which makes unboxing a needed (after the dev discover the error at runtime).

We have two solutions to fix this:

  • Make it obj as we have done for other items, I assume the runtime will automatically transform things as numbers to string, but it may not be the format they expect.
  • Make it U2<string, string[]>, which will break a lot of code forcing devs to add !^ everywhere.

What do you think? @MangelMaxime @nojaf

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0