8000 Replace libheif and its dependencies with extension on GNOME 49 · Issue #414 · flathub/org.gimp.GIMP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace libheif and its dependencies with extension on GNOME 49 #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Erick555 opened this issue Mar 17, 2025 · 7 comments
Open

Replace libheif and its dependencies with extension on GNOME 49 #414

Erick555 opened this issue Mar 17, 2025 · 7 comments

Comments

@Erick555
Copy link
Contributor

Since gnome 47 and later the org.freedesktop.Platform.ffmpeg-full extension includes HEIC support. It can replace internal org.gimp.GIMP.HEIC extension and bundling libheif and its dependencies in gimp.

https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/issues/1704

#262
@Erick555 Erick555 mentioned this issue Mar 17, 2025
Merged
@Erick555
Copy link
Contributor Author

Instructions about using the extension can be found here: https://docs.flatpak.org/en/latest/extension.html#loading-existing-extensions

@brunvonlope
Copy link
Collaborator
brunvonlope commented Mar 17, 2025 •
edited
Loading

Looking better at the docs, seems that I need to point to the extension "version". This would be even harder to maintain than the Clang sdk-extension, which we dropped (0499290) because it was a absolute hell to match GNOME Runtime with Freedesktop SDK, specially on the Nightly repo

@Erick555
Copy link
Contributor Author

No, it should be easy. Version should match Freedesktop SDK version that gnome uses. For gnome 48 version will always be 24.08. For gnome 49 and beyond the extension will be handled automatically by runtime and it could be entirely removed from app manifest. So as long as you use gnome 48 use 24.08 extension and on next runtime update you remove it completely.

Below should work right now:


    "add-extensions": {
        "org.freedesktop.Platform.ffmpeg-full": {
            "directory": "lib/ffmpeg",
            "version": "24.08",
            "add-ld-path": ".",
            "no-autodownload": false
        }
    },
    "cleanup-commands": [
        "mkdir -p /app/lib/ffmpeg"
    ],

@Erick555
Copy link
Contributor Author

The only obstacle I see is that gimp is currently doing some multi-stage build for x265. This is something runtime is lacking. Perhaps it could be replicated there if someone sends MR.

@brunvonlope
Copy link
Collaborator

Don't take me wrong, I would do love to not have to build x265 anymore (it's a problematic dep) and libheif too.

But whoever implements this needs to do the gnome<>freedesktop matching in both stable and beta branches and in nightly repo too every release and take possible regressions (e.g.: #384) on shoulders.

@Erick555
Copy link
Contributor Author
Erick555 commented Mar 18, 2025 •
edited
Loading

Since 24.08 will be the last version controlled by apps the matching in this context would mean removing extension entirely from the manifest on next gnome runtime update (48->49) which will be released on september. After that this will be de facto part of the runtime like mesa is thus always available for every app and there will be no matching involved. If you want to minimize effort then you may wait with it until gnome 49.

@brunvonlope
Copy link
Collaborator

Thanks. I will wait to GNOME Runtime 49, then.

@brunvonlope brunvonlope changed the title Replace libheif and its dependencies with org.freedesktop.Platform.ffmpeg-full extension Replace libheif and its dependencies with extension on GNOME 49 Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Erick555 @brunvonlope
0