8000 Git-aware notification does not work if branch not defined · Issue #20 · flowdock/flowdock-api · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Git-aware notification does not work if branch not defined #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ilkka opened this issue Oct 15, 2013 · 1 comment
Open

Git-aware notification does not work if branch not defined #20

ilkka opened this issue Oct 15, 2013 · 1 comment

Comments

@ilkka
Copy link
ilkka commented Oct 15, 2013

I've purposefully not set :branch in my Capfile, to be able to deploy the currently checked out branch. This causes notifications to fail, however, wth

    triggering after callbacks for `deploy'
  * 2013-10-15 10:47:00 executing `flowdock:notify_deploy_finished'
    triggering before callbacks for `flowdock:notify_deploy_finished'
  * 2013-10-15 10:47:00 executing `flowdock:set_flowdock_api'
Flowdock: error in sending notification to your flow: undefined local variable or method `branch' for #<Capistrano::Configuration::Namespaces::Namespace:0x007fcff24d2168>
  * 2013-10-15 10:47:00 executing `flowdock:save_deployed_branch'
  * executing "echo 'HEAD' > /path/to/myapp/current/BRANCH"

I think the process should be smart enough to git rev-parse --abbrev-ref HEAD if the branch has not been given.
@blackxored
Copy link

@ilkka I've since moved on to capistrano 3, but can you check if the problem persists in this branch?

Gemfile excerpt:

gem 'flowdock', github: 'blackxored/flowdock-api', branch: 'fix-undefined-branch'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilkka @blackxored
0