8000 Add Windows Arm64 machines to the Flutter try pool · Issue #141986 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Windows Arm64 machines to the Flutter try pool #141986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
loic-sharma opened this issue Jan 22, 2024 · 7 8000 comments
Closed

Add Windows Arm64 machines to the Flutter try pool #141986

loic-sharma opened this issue Jan 22, 2024 · 7 comments
Assignees
@godofredoc
Labels
infra: device lab Infrastructure device lab problems P3 Issues that are less important to the Flutter project platform-target-arm Targeting an ARM-based platform platform-windows Building on or for Windows specifically team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team

Comments

@loic-sharma
Copy link
Member

Type of Request

feature request

Infrastructure Environment

DeviceLab

What is happening?

Flutter cannot run Windows Arm64 pre-submit DeviceLab tests

Steps to reproduce

The Flutter try pool does not have any Windows Arm64 machines. Any pull request with a pre-submit Windows Arm64 test will fail.

Example pull request: #137675

Example failure: https://ci.chromium.org/ui/p/flutter/builders/try/Windows_arm64%20plugin_test_windows/3/overview

This build failed due to resource exhaustion.

Expected results

No response
@loic-sharma loic-sharma added team-infra Owned by Infrastructure team platform-windows Building on or for Windows specifically platform-target-arm Targeting an ARM-based platform fyi-desktop labels Jan 22, 2024
This was referenced Jan 22, 2024
Merged
Merged
@loic-sharma
Copy link
Member Author

FYI this isn't a high priority. For now we can work around this by making all Windows Arm64 DeviceLab tests post-submit: #141987

@loic-sharma loic-sharma mentioned this issue Jan 22, 2024
Open
17 tasks
@christopherfujino
Copy link
Contributor

Not sure how much overall Windows arm64 capacity we have, but if it's not a lot, splitting that among pre and post submit and requiring presubmit arm64 tests for ALL PRs might be a net negative, especially given the percentage of all changes which would potentially ONLY break windows arm64.

Would having 1 bot available for manual LED tests be sufficient, or do you want to enforce testing for every PR presubmit?

@christopherfujino
Copy link
Contributor
christopherfujino commented Jan 22, 2024 •
edited
Loading

If it's even less frequently needed, I think Googlers can request 24 hour permissions to schedule prod led builds.

@loic-sharma
Copy link
Member Author
loic-sharma commented Jan 23, 2024 •
edited
Loading

Would having 1 bot available for manual LED tests be sufficient

Yup this would be fine for now.

@yusuf-goog yusuf-goog added the P3 Issues that are less important to the Flutter project label Jan 23, 2024
@yusuf-goog
Copy link
Contributor
yusuf-goog commented Jan 23, 2024 •
edited
Loading

I would suggest that the minimum number of bots in try if any builds are blocking (would turn the tree red), should be >= 3.

We should take that and the limited inventory of these devices into account when planning our deployment strategy.

@yusuf-goog yusuf-goog added infra: device lab Infrastructure device lab problems triaged-infra Triaged by Infrastructure team labels Jan 23, 2024
auto-submit bot pushed a commit that referenced this issue Jan 29, 2024
@loic-sharma
[Windows Arm64] Run plugin test post-submit (#141987)
f727948 
The Flutter try pool does not have any Windows Arm64 machines. Thus, any Windows Arm64 pre-submit tests will fail as there's no machines to run them.

This converts the only Windows Arm64 pre-submit test, the plugin test, to run post-submit.

See: #141986
@loic-sharma loic-sharma mentioned this issue Feb 20, 2024
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Feb 21, 2024
@loic-sharma
[ci] Run Windows Arm64 build tests post-submit (#6166)
9c15ec5 
The Flutter try pool does not have any Windows Arm64 machines. Thus, any Windows Arm64 pre-submit tests would fail without `bringup: true` as there's no machines to run them.

This change will allow us to promote the Windows Arm64 build tests out of `bringup`.

See: flutter/flutter#141986
Part of flutter/flutter#129813
@godofredoc godofredoc self-assigned this Apr 12, 2024
@godofredoc
Copy link
Contributor

This is now complete:

image

@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@godofredoc godofredoc

Labels
infra: device lab Infrastructure device lab problems P3 Issues that are less important to the Flutter project platform-target-arm Targeting an ARM-based platform platform-windows Building on or for Windows specifically team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

No branches or pull req 339E uests
5 participants
@loic-sharma @christopherfujino @gspencergoog @godofredoc @yusuf-goog
0