[hcpp] Change hcpp view controller class to just use existing hybrid composition view controller. #164214

jonahwilliams · 2025-02-26T18:28:07Z

We probably don't want to have completely separate constructors? Code should check if supported and use the appropriate runtime controller internally.

jmagman · 2025-02-28T18:17:49Z

@jonahwilliams Is the constructor exposed to be used by plugins? Or is this an internal-only constructor and this issue is just tracking DRYing out some duplicated code?

jonahwilliams · 2025-02-28T19:05:58Z

This was Reid's suggestion from the deep dive sync. Right now the way you declare HC and HC++ mode is slightly different:

HC mode:

   return PlatformViewLink(
      viewType: viewType,
      surfaceFactory: (BuildContext context, PlatformViewController controller) {
        return AndroidViewSurface(
          controller: controller as AndroidViewController,
          gestureRecognizers: const <Factory<OneSequenceGestureRecognizer>>{},
          hitTestBehavior: PlatformViewHitTestBehavior.opaque,
        );
      },
      onCreatePlatformView: (PlatformViewCreationParams params) {
        return PlatformViewsService.initExpensiveAndroidView(
            id: params.id,
            viewType: viewType,
            layoutDirection: TextDirection.ltr,
            creationParamsCodec: const StandardMessageCodec(),
          )
          ..addOnPlatformViewCreatedListener(params.onPlatformViewCreated)
          ..create();
      },
    );

HC++ Mode

   return PlatformViewLink(
      viewType: viewType,
      surfaceFactory: (BuildContext context, PlatformViewController controller) {
        return AndroidViewSurface(
          controller: controller as AndroidViewController,
          gestureRecognizers: const <Factory<OneSequenceGestureRecognizer>>{},
          hitTestBehavior: PlatformViewHitTestBehavior.opaque,
        );
      },
      onCreatePlatformView: (PlatformViewCreationParams params) {
        return PlatformViewsService.initHybridAndroidView(
            id: params.id,
            viewType: viewType,
            layoutDirection: TextDirection.ltr,
            creationParamsCodec: const StandardMessageCodec(),
          )
          ..addOnPlatformViewCreatedListener(params.onPlatformViewCreated)
          ..create();
      },
    );

But on the other hand if you wrap all this in a higher level widget like I suggest in #164215 then it doesn't really matter

jonahwilliams added P1 High-priority issues at the top of the work list team-android Owned by Android platform team labels Feb 26, 2025

gmackall self-assigned this Feb 27, 2025

gmackall added P2 Important issues not at the top of the work list engine flutter/engine repository. See also e: labels. triaged-android Triaged by Android platform team and removed P1 High-priority issues at the top of the work list labels Feb 27, 2025

reidbaker assigned reidbaker and unassigned gmackall Apr 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[hcpp] Change hcpp view controller class to just use existing hybrid composition view controller. #164214

[hcpp] Change hcpp view controller class to just use existing hybrid composition view controller. #164214

[hcpp] Change hcpp view controller class to just use existing hybrid composition view controller. #164214

[hcpp] Change hcpp view controller class to just use existing hybrid composition view controller. #164214

Comments