8000 Update engine script create_ios_framework to optionally take ARM simulator path · Issue #73066 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update engine script create_ios_framework to optionally take ARM simulator path #73066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmagman opened this issue Dec 29, 2020 · 3 comments
Closed
Assignees
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-host-arm Building on an ARM-based platform platform-ios iOS applications specifically

Comments

@jmagman
Copy link
Member
jmagman commented Dec 29, 2020

In preparation for an ARM simulator framework update create_ios_framework to replace --simulator-out-dir with --simulator-x86-out-dir and --simulator-arm64-out-dir. lipo the simulator frameworks together.

When that's done, update the recipe logic that calls this script to pass in --simulator-x86-out-dir.
When #64502 is ready, it will additionally pass in --simulator-arm64-out-dir.

Don't remove deprecated --simulator-out-dir until after the recipe is updated to avoid breaking changes.

@jmagman jmagman added platform-ios iOS applications specifically engine flutter/engine repository. See also e: labels. labels Dec 29, 2020
@jmagman jmagman self-assigned this Dec 29, 2020
@pedromassangocode pedromassangocode added passed first triage platform-host-arm Building on an ARM-based platform labels Dec 29, 2020
@kf6gpe kf6gpe added the P2 Important issues not at the top of the work list label Jan 5, 2021
@jmagman jmagman removed their assignment Jan 29, 2021
@gw280 gw280 self-assigned this Jan 29, 2021
@gw280
Copy link
Contributor
gw280 commented Apr 12, 2021

Quick update: the engine scripts are ready and mostly work (I just need to do a minor fix and re-land flutter/buildroot#437), but there's an issue that needs to be resolved on CI before we can modify the recipes.

In order to build for arm64 simulator, we need to use Xcode 12.0.0 or newer, and thus we can't use our own llvm. As a result, we can't use goma to build, which means the build takes longer. Adding a new arm64 simulator build step to the existing iOS builder hits the timeout ceiling and so the build fails.

After speaking with @godofredoc and @CaseyHillers, it looks like they're working on refactoring the existing CI recipes to allow for these builds to be sharded out and have cross-dependencies, which we would need in order to add the arm64 simulator builds.

@gw280
Copy link
Contributor
gw280 commented Jun 16, 2021

Closing in favour of #84672 as the other work is all done/merged.

@gw280 gw280 closed this as completed Jun 16, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-host-arm Building on an ARM-based platform platform-ios iOS applications specifically
Projects
None yet
Development

No branches or pull requests

4 participants
0