8000 Adding ARM iOS simulator times out the engine artifacts build · Issue #82736 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adding ARM iOS simulator times out the engine artifacts build #82736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jmagman opened this issue May 17, 2021 · 7 com 8000 ments
Closed

Adding ARM iOS simulator times out the engine artifacts build #82736

jmagman opened this issue May 17, 2021 · 7 comments
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team

Comments

@jmagman
Copy link
Member
jmagman commented May 17, 2021 •
edited
Loading

Adding the ARM iOS simulator to the Mac iOS Engine builder causes the tasks to take an additional 15 minutes, which pushes the build over the timeout limit. This is particularly long because currently the ARM builds do not use goma.

This is blocking iOS ARM simulator and native M1 macOS development.
#60113
#60118
@jmagman jmagman added engine flutter/engine repository. See also e: labels. team-infra Owned by Infrastructure team labels May 17, 2021
@jmagman
Copy link
Member Author
jmagman commented May 17, 2021 •
edited
Loading

Some solutions that have been discussed:

  1. Refactor recipes to handle build dependencies. Frameworks can be built in parallel, and then a final publication build will gather, package, and publish the artifacts. This work is currently in the infra team's Q3 OKRs. @gw280 has already outlined the dependency graph Separate engine builds to build, test archive components #81855
  2. Add a build conductor to kick off the dependencies, idle, then gather, package, and publish the artifacts. This wastes a builder that waits for the sub builds to finish, and it very similar to the sharded test functionality that was deprecated in the Flutter framework. This would be an easier refactor than option 1, but would waste a resource.
  3. Adopt goma for iOS/macOS bitcode builds. This may push the entire builder under the timeout limit. Update the buildroot to use our own clang when building with bitcode-marker #39281. GOMA team says this isn't currently possible Adding ARM iOS simulator times out the engine artifacts build #82736 (comment)

Any of these changes would have the added eng-prod benefit of improving engine testing time. Option 1 or 2 would also allow future framework variants to be built in parallel (openGL for example).

@jmagman
Copy link
Member Author
jmagman commented May 17, 2021

\cc @dnfield @godofredoc @gw280

@jmagman jmagman changed the title Adding ARM iOS simulator builds makes the engine artifacts builder time out Adding ARM iOS simulator times out the engine artifacts build May 17, 2021
@jmagman jmagman mentioned this issue May 17, 2021
Closed
35 tasks
@dnfield
Copy link
Contributor
dnfield commented May 17, 2021

I know the last time we asked, it was not possible to add the clang versions we to support this on GOMA - but maybe now that it's on RBE that's changed. I'll see if we can reach out to the Fuchsia GOMA folks about that...

@dnfield
Copy link
Contributor
dnfield commented May 17, 2021

I know the last time we asked, it was not possible to add the clang versions we to support this on GOMA - but maybe now that it's on RBE that's changed. I'll see if we can reach out to the Fuchsia GOMA folks about that...

Per GOMA team, this isn't possible due to GOMA's architecture. Mac compilation is done by cross compiling with a compatible Linux based toolchain. There's no such thing for the Xcode toolchains.

@jmagman
Copy link
Member Author
jmagman commented May 17, 2021

Thanks for checking @dnfield

@chinmaygarde chinmaygarde added the P2 Important issues not at the top of the work list label May 24, 2021
@jmagman
Copy link
Member Author
jmagman commented Jun 22, 2021

The engine build does not time out when the ARM simulator step was added in https://flutter-review.googlesource.com/c/recipes/+/14780.
Closing.

@jmagman jmagman closed this as completed Jun 22, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees 4628
No one assigned
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chinmaygarde @jmagman @dnfield @godofredoc
0