8000 [google_sign_in] Update GoogleSignIn dependency to 6.2 · Issue #86436 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[google_sign_in] Update GoogleSignIn dependency to 6.2 #86436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stuartmorgan-g opened this issue Jul 14, 2021 · 13 comments · Fixed by flutter/plugins#5708
Closed

[google_sign_in] Update GoogleSignIn dependency to 6.2 #86436

stuartmorgan-g opened this issue Jul 14, 2021 · 13 comments · Fixed by flutter/plugins#5708
Assignees
@jmagman
Labels
p: google_sign_in The Google Sign-In plugin P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically

Comments

@stuartmorgan-g
Copy link
Contributor

We're currently using 5.0; 6.0 was just released. This isn't pressing, but it would be good to handle the API updates relatively soon so that we're not stuck dealing with that suddenly if there's a bug fix we need.

(6.0 also adds SPM support, which would be relevant for those investigations.)

/cc @jmagman
@stuartmorgan-g stuartmorgan-g added platform-ios iOS applications specifically plugin p: google_sign_in The Google Sign-In plugin P3 Issues that are less important to the Flutter project labels Jul 14, 2021
@jmagman
Copy link
Member
jmagman commented Jul 14, 2021

Wow you beat me by a minute. More details in #86435

@jmagman jmagman mentioned this issue Jul 14, 2021
Closed
@jmagman
8000 Copy link
Member
jmagman commented Jul 14, 2021 •
edited
Loading

Bumping to a P3 to prevent users from having to do the same workaround from flutter/plugins#4128.

@jmagman jmagman self-assigned this Jul 14, 2021
@jmagman jmagman added P1 High-priority issues at the top of the work list and removed P3 Issues that are less important to the Flutter project labels Jul 14, 2021
@jmagman jmagman mentioned this issue Jul 15, 2021
Merged
11 tasks
@jmagman jmagman mentioned this issue Jul 15, 2021
Open
@remideneleaodocs remideneleaodocs mentioned this issue Jul 19, 2021
Closed
@jmagman
Copy link
Member
jmagman commented Jul 20, 2021 •
edited
Loading

GoogleSignIn 6.0 doesn't allow scopes to be requested at the same time as sign in. That means we need to sign in, then request the scopes previously specified during initialization. So sign in happens, then immediately there's a separate permissions flow:

Screen Shot 2021-07-20 at 4 35 29 PM
126408362-9264b92d-0a12-45f5-8bd1-8450cc1e8196

Then it asks for permission AGAIN:
Screen Shot 2021-07-20 at 4 37 38 PM
126408396-40960688-a63b-47d6-9e24-36f17b665f58

I'm not sure this is an acceptable user experience. What do you think, @stuartmorgan?

@stuartmorgan-g
Copy link
Contributor Author

It doesn't seem great. Maybe we should give that issue a little while to see how things proceed; if it's going to be changed we can wait, and if not maybe we take a look at whether we need a significant breaking change to our API to itself be based on incremental auth?

@jmagman
Copy link
Member
jmagman commented Jul 21, 2021

\cc @petea

@stargazing-dino
Copy link

I'm not sure on the timeline of this happening but this issue was quite a headache for me to track down. It'd be nice if there were a note in the google_sign_in docs (and any other package that doesn't support ARM iOS) for this issue and perhaps linking to the workaround used to fix #85713 if it'll be some time before this change happens

@jmagman
Copy link
Member
jmagman commented Jul 27, 2021

@Nolence #85713 is where we're tracking that the flutter tool isn't handling plugins that don't support ARM simulators. That issue needs to be fixed regardless of whether GoogleSignIn 6.0 is adopted.

@stargazing-dino
Copy link

Ah, that makes sense. Thanks for the clarification

This was referenced Jul 29, 2021
Closed
Merged
@cpboyd cpboyd mentioned this issue Aug 5, 2021
Closed
@maks
Copy link
maks commented Mar 9, 2022

Just as FYI, even though #85713 fixed the build problems (thank you @jmagman !) this is still tripping up people who in a foolhardy fit of optimism stopped running the Simulator under Rosetta, then later started using Firebase Auth (which makes an app have a transitive dependency on google_sign_in) and then run into the rosetta-on-non-rosetta simulator class of bugs such as the broken scrolling from: #79641

Would there be any thoughts on when at least ver 5 could be adopted by the plugin to get support for arm64 simulators?

@stuartmorgan-g
Copy link
Contributor Author

See google/GoogleSignIn-iOS#23 (comment)

@stuartmorgan-g stuartmorgan-g mentioned this issue Apr 4, 2022
Closed
@tudor07
Copy link
tudor07 commented Apr 5, 2022

Almost 1 year since this issue was open, what's the hold up?

@stuartmorgan-g
Copy link
Contributor Author

what's the hold up?

See the discussion above, as well as this comment about the upstream issue.

@jmagman jmagman mentioned this issue Apr 14, 2022
Closed
@jmagman jmagman changed the title [google_sign_in] Update GoogleSignIn dependency to 6.0 [google_sign_in] Update GoogleSignIn dependency to 6.2 May 13, 2022
@jmagman jmagman mentioned this issue May 13, 2022
Merged
11 tasks
@jmagman jmagman mentioned this issue May 25, 2022
Merged
8 tasks
@github-actions
Copy link
github-actions bot commented Jun 2, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmagman jmagman

Labels
p: google_sign_in The Google Sign-In plugin P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[google_sign_in] Upgrade to GoogleSignIn 6.2, support arm64 simulators jmagman/plugins
6 participants
@maks @stuartmorgan-g @jmagman @tudor07 @stargazing-dino @TahaTesser
0