8000 [flutter_conductor] ensure macOS arm Dart sdk is codesigned · Issue #97536 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[flutter_conductor] ensure macOS arm Dart sdk is codesigned #97536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christopherfujino opened this issue Jan 31, 2022 · 5 comments
Closed

[flutter_conductor] ensure macOS arm Dart sdk is codesigned #97536

christopherfujino opened this issue Jan 31, 2022 · 5 comments
Assignees
@christopherfujino
Labels
P2 Important issues not at the top of the work list

Comments

@christopherfujino
Copy link
Contributor

before Flutter can distribute a macOS ARM Dart SDK, it must be codesigned and notarized.
@christopherfujino christopherfujino added the P2 Important issues not at the top of the work list label Jan 31, 2022
@christopherfujino christopherfujino self-assigned this Jan 31, 2022
@christopherfujino christopherfujino mentioned this issue Feb 1, 2022
Merged
@jmagman
Copy link
Member
jmagman commented Feb 1, 2022

Part of #86926

@jmagman jmagman mentioned this issue Feb 1, 2022
Closed
@zanderso
Copy link
Member
zanderso commented Feb 1, 2022 •
edited
Loading

@christopherfujino Could you give a pointer into the conductor code that has the signing logic that needs to be modified? If so, I can take a look, and ping you if I have questions.

@christopherfujino
Copy link
Contributor Author

@christopherfujino Could you give a pointer into the conductor code that has the signing logic that needs to be modified?

I've got a change ready, I just need to locally test it.

@christopherfujino
Copy link
Contributor Author
christopherfujino commented Feb 1, 2022 •
edited
Loading

The script is updated and I verified it on the commit: https://github.com/flutter/engine/tree/b0e6fe8e8006414b6a2c8f71ae4af8b1cb03dde4.

This can be verified on a mac with:

curl -lO https://storage.googleapis.com/flutter_infra_release/flutter/b0e6fe8e8006414b6a2c8f71ae4af8b1cb03dde4/dart-sdk-darwin-arm64.zip
unzip ./dart-sdk-darwin-arm64.zip
codesign -vvv ./dart-sdk/bin/dart

and it should say:

dart-sdk/bin/dart: valid on disk
dart-sdk/bin/dart: satisfies its Designated Requirement

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christopherfujino christopherfujino

Labels
P2 Important issues not at the top of the work list
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmagman @zanderso @christopherfujino
0