8000 FallBackEncoding not applied on C-Find request when no SpecificCharacterSet tag is present · Issue #1159 · fo-dicom/fo-dicom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content 8000
FallBackEncoding not applied on C-Find request when no SpecificCharacterSet tag is present #1159
Closed
@Jarekw69

Description

@Jarekw69

When no SpecificCharacterSet tag is provided in C-Find request to foDicom based SCP, foDicom seems to use default charset (i.e. ASCII) to decode e.g. PN tags, which results in '?' in place of certain chars. After a quick look at the source,
was it intentional for any reason to use DicomDatasetReaderObserver contructor with only a command (DicomService->ProcessPDataTFAsync) instead of providing also the fallBackEncoding available in DicomService?
e.g.
var reader = new DicomReader(); reader.IsExplicitVR = false; reader.Read(new StreamByteSource(_dimseStream, FileReadOption.Default), new DicomDatasetReaderObserver(command, _fallbackEncoding));
instead of:
var reader = new DicomReader(); reader.IsExplicitVR = false; reader.Read(new StreamByteSource(_dimseStream, FileReadOption.Default), new DicomDatasetReaderObserver(command));

Best regards
Jarek

Fellow Oak DICOM 4.0.7
OS: Windows 10 x64
Platform: NET Framework 4.5.2

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0