8000 Zulu Prime JREs miscategorised as JDKs · Issue #94 · foojayio/discoapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Zulu Prime JREs miscategorised as JDKs #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JackPGreen opened this issue Feb 12, 2024 · 9 comments
Open

Zulu Prime JREs miscategorised as JDKs #94

JackPGreen opened this issue Feb 12, 2024 · 9 comments

Comments

@JackPGreen
Copy link
JackPGreen commented Feb 12, 2024 •
edited
Loading

Take this request, which queries for package_type=jdk, but one of the results is:

"package_type": "jdk",
"filename": "zing24.01.0.0-4-jre17.0.10-linux_x64.tar.gz",

I.E. not a JDK, actually a JRE.

This looks to happen for other Zulu Prime versions as well.

Full request response:

{
  "result": [
    {
      "id": "9c5236e6bdb708a7e7c229f14dde4473",
      "archive_type": "tar.gz",
      "distribution": "zulu_prime",
      "major_version": 17,
      "java_version": "17.0.10+7",
      "distribution_version": "24.1",
      "jdk_version": 17,
      "latest_build_available": true,
      "release_status": "ga",
      "term_of_support": "lts",
      "operating_system": "linux",
      "lib_c_type": "glibc",
      "architecture": "x64",
      "fpu": "unknown",
      "package_type": "jdk",
      "javafx_bundled": false,
      "directly_downloadable": true,
      "filename": "zing24.01.0.0-4-jre17.0.10-linux_x64.tar.gz",
      "links": {
        "pkg_info_uri": "https://api.foojay.io/disco/v3.0/ids/9c5236e6bdb708a7e7c229f14dde4473",
        "pkg_download_redirect": "https://api.foojay.io/disco/v3.0/ids/9c5236e6bdb708a7e7c229f14dde4473/redirect"
      },
      "free_use_in_production": true,
      "tck_tested": "unknown",
      "tck_cert_uri": "",
      "aqavit_certified": "unknown",
      "aqavit_cert_uri": "",
      "size": 139615096,
      "feature": []
    },
    {
      "id": "df81636b87e993bca6a57b61d4d43893",
      "archive_type": "tar.gz",
      "distribution": "zulu_prime",
      "major_version": 17,
      "java_version": "17.0.10+7",
      "distribution_version": "24.1",
      "jdk_version": 17,
      "latest_build_available": true,
      "release_status": "ga",
      "term_of_support": "lts",
      "operating_system": "linux",
      "lib_c_type": "glibc",
      "architecture": "x64",
      "fpu": "unknown",
      "package_type": "jdk",
      "javafx_bundled": false,
      "directly_downloadable": true,
      "filename": "zing24.01.0.0-4-jdk17.0.10-linux_x64.tar.gz",
      "links": {
        "pkg_info_uri": "https://api.foojay.io/disco/v3.0/ids/df81636b87e993bca6a57b61d4d43893",
        "pkg_download_redirect": "https://api.foojay.io/disco/v3.0/ids/df81636b87e993bca6a57b61d4d43893/redirect"
      },
      "free_use_in_production": true,
      "tck_tested": "unknown",
      "tck_cert_uri": "",
      "aqavit_certified": "unknown",
      "aqavit_cert_uri": "",
      "size": 311739932,
      "feature": []
    }
  ],
  "message": "2 package(s) found"
}
@JackPGreen
Copy link
Author

It looks like in ZuluPrime#getAllPkgs, it's hard coded to assume pkg.setPackageType(JDK).

I'd guess a simple solution would be something like pkg.setPackageType(filename.contains("jre") ? JRE : JDK) as done elsewhere, but I'm not able to run the project to test this.

@HanSolo
Copy link
Collaborator
HanSolo commented Feb 12, 2024
8000

Will take a look at it, thx for reporting

@HanSolo
Copy link
Collaborator
HanSolo commented Feb 12, 2024

Found 23 wrong packages and removed them, so they should be added with the next update run after the deployment will be done, so probably by tomorrow all packages should be back again with the correct package type.

@JackPGreen JackPGreen reopened this Feb 14, 2024
@JackPGreen
Copy link
Author

@HanSolo this had been fixed but is happening again?

@HanSolo
Copy link
Collaborator
HanSolo commented Feb 14, 2024

Darn...did another deployment yesterday and probably have a regression here...will take a look...thx for the heads up

@HanSolo
Copy link
Collaborator
HanSolo commented Feb 14, 2024

Deployment is ongoing...should be fixed in around 2 hours (fingers crossed :))

@JackPGreen
Copy link
Author

Deployment is ongoing...should be fixed in around 2 hours (fingers crossed :))

Still showing 2 package results unfortunately.

@HanSolo
Copy link
Collaborator
HanSolo commented Feb 15, 2024

Now this is interesting...on the staging and testing environment it doesn't show the wrong pkgs but on production it does...hmm...need to take a closer look why this happens

@JackPGreen
Copy link
Author
JackPGreen commented Feb 20, 2024 •
edited
Loading

This is now showing one package - fixed or intermittent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HanSolo @JackPGreen
0