8000 [Bug] Large Diff Button Display After Every Stage! · Issue #2347 · fork-dev/Tracker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Bug] Large Diff Button Display After Every Stage! #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdsterG opened this issue May 6, 2025 · 12 comments
Open

[Bug] Large Diff Button Display After Every Stage! #2347

EdsterG opened this issue May 6, 2025 · 12 comments

Comments

@EdsterG
Copy link
EdsterG commented May 6, 2025

For files that have large diffs, every time I stage one or more lines, the large diff prompt shows up! I already hit "load diff" once, am still working with the same file, it doesn't make sense to show it every time I stage 1 line.

How can I disable the large diff default? I want to load large diff by default.

@DanPristupov
Copy link
Contributor

How can I disable the large diff default? I want to load large diff by default.

There is no such option.

@EdsterG
Copy link
Author
EdsterG commented May 6, 2025

That's unfortunate, I recently update Fork and this started happening. Might have to revert until this is fixed :(

@DanPristupov
Copy link
Contributor

I recently update Fork and this started happening

I think it worked this way all the time. I just tried an older version and the behavior is the same.

@EdsterG
Copy link
Author
EdsterG commented May 7, 2025

Have you tried 2.37?

@haraldblatand
Copy link
haraldblatand commented May 11, 2025

@DanPristupov : no, I experience the same 'large diff button pops up after every commit' only since the latest version: 2.52.0

I use Fork on 3 Mac's of which 2 are quite old, running OS X El Capitan, where I use Fork 2.16
On my modern iMac, I run 2.52.0, and only since the last update some week(s) ago, I have this behavior.

Even if there are only 2 lines different, the 'large diff' button is shown. The problem is that this often happens, but not always, so I do not know the exact conditions to reproduce it.

I recently switched to an Azure project, but I can try next week if the problem is reproducable in the Github project the Git project came from - if you are interested.
Next week, I will be able to use another iMac with a late Fork, test and then upgrade that Fork and test.

@DanPristupov
Copy link
Contributor

@haraldblatand if lines are too long, then they are also 'too large to display'

@haraldblatand
Copy link

Sorry for the delay. Here is an example:

Running on Mac OS 14.7.5, the file BaanvakkenAsInGit.tcd is the instance of the file Baanvakken.tcd as known in Git, BaanvakkenWithSomeDiffs.tcd is the instance of that file with only a few differences and no long lines. The files are maintained as Baanvakken.tcd in iTrain, a model railway program and are XML.

Fork 2.52.0 shows the 'large diff' button see Fork2.52.0 MessageLargeDiffs.png and Fork2.52.0 TheseAreAllTheDiffs.png
Fork 2.50.1 does not show the 'large diff' button, see Fork2.50.1 NoMessageLargeDiffs.png

The two instances of Baanvakken.tcd are in Baanvakken.zip

The 'large diff' button is often shown in 2.52.0 but not always in similar circumstances with say not big deal differences. The XML is in my opinion poor quality, but I don't know if some diff algorithm screws up. I also attached the zipped preferences of Fork. In my .gitattributes there is only one line: .tcd .xml

Baanvakken.zip

com.DanPristupov.Fork.plist.zip

Image Image Image

@EdsterG
Copy link
Author
EdsterG commented May 20, 2025

Oh nice, how do I download 2.50.0?

@DanPristupov
Copy link
Contributor

@EdsterG
Copy link
Author
EdsterG commented May 20, 2025

Thank you! I can confirm 2.50.1 fixes my issue with the large diff. Specifically, I suspect the threshold or algorithm for detecting large diffs changed between 2.50.1 and 2.51.0. I highly prefer the user experience in 2.50.1.

@DanPristupov
Copy link
Contributor
DanPristupov commented May 20, 2025

The limit has been existing for many years, however because of a bug it didn't work as expected. We fixed this recently :).

I just checked, it seems that since that the performance of the text control got improved or the computers became much faster and now I don't see the freeze anymore. So, we'll increase the limit in the next update.

@haraldblatand thank you for the example 👍. You helped me to find the problem quickly.

@EdsterG
Copy link
Author
EdsterG commented May 20, 2025

Would it be possible to just make this a toggle-able setting? I personally find large diff blocking to be very distracting, even for large files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3395
Development

No branches or pull requests

3 participants
0